GNOME Bugzilla – Bug 566073
Orca provides the "tree level" for items in submenus within Firefox 3.x
Last modified: 2009-01-05 19:15:27 UTC
When one first arrows into a Firefox submenu (e.g. Page Style, Toolbars), Orca speaks the tree level associated with the item which received focus as a result. The item which received focus is, of course, not in a tree and therefore a level should not be spoken. The reason for this bug has to do with the way we're getting the node level in the Gecko script, namely by looking for the attribute "level". In addition to items within trees, this attribute is present for headings (currently checked for) and -- it turns out -- items in submenus. :-) We need to check for that condition as well.
Created attachment 125547 [details] [review] fix plus regression test updates The fix is a one-liner: Check to see if the parent of the item in question is of ROLE_MENU. If it is, we're not in a tree. This patch also includes updates to the regression tests, mostly removing the "BUG?" lines associated with this bug, but also a bit more work to make the tests be usable for both Firefox 3.0.5 and Firefox 3.1beta2. The fix has been regression tested for both versions of Firefox, and (of course) pylinted. :-) Given that this is another very limited change, I've gone ahead and committed this to trunk. I realize that I've done this a few times now. It won't become my modus operandi, honest. :-) We just need to get the tests in shape and the low-hanging (ground-resting) fruit out of the way so that we can do proper testing of the more significant patches awaiting feedback.
This seems safe and appropriate for gnome-2-24 as well. Joanie -- if you agree, please check it into gnome-2-24.
Done. The regression tests are so different now that I didn't commit the test changes; just the fix. :-) Readjusting the milestone.