After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 566043 - dasher doesn't build with --disable-a11y --disable-speech --without-cairo --without-gnome
dasher doesn't build with --disable-a11y --disable-speech --without-cairo --w...
Status: RESOLVED FIXED
Product: dasher
Classification: Applications
Component: general
4.9.x
Other Linux
: Normal normal
: ---
Assigned To: Patrick Welche
dasher-maint
Depends on:
Blocks:
 
 
Reported: 2008-12-30 12:17 UTC by Gilles Dartiguelongue
Modified: 2009-03-02 17:14 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
dasher-4.9.0-i18n.patch (271 bytes, patch)
2008-12-30 12:18 UTC, Gilles Dartiguelongue
rejected Details | Review

Description Gilles Dartiguelongue 2008-12-30 12:17:06 UTC
one of these switch controls GNOME_LIBS which in turn controls inclusion of headers responsible for defining N_() macro which is used in Src/main.cc

Downstream report:
https://bugs.gentoo.org/show_bug.cgi?id=249090
Comment 1 Gilles Dartiguelongue 2008-12-30 12:18:40 UTC
Created attachment 125524 [details] [review]
dasher-4.9.0-i18n.patch

tentative patch I wrote to fix the issue. It allows building but I'm not sure this is what you would like to see as there is a lot of custom code that is generally up to glib to take care of.

 I18n.h |    5 +++++
 1 file changed, 5 insertions(+)
Comment 2 Gilles Dartiguelongue 2008-12-30 12:32:56 UTC
looks like I did something wrong :p

------- Comment #4 From Diego E. 'Flameeyes' Pettenò 2008-12-30 12:14:58 0000 [reply] -------

The patch looks wrong, N_ is used when you cannot call a function, and should
thus be defined always N_(x) (x).

This is used for instance during structure definitions, where you cannot call a
function at runtime, but still want to mark the string as viable for
translation. The structure member is later passing through gettext explicitly.

Comment 3 Gilles Dartiguelongue 2008-12-30 12:33:21 UTC
erm, fixing patch status.
Comment 4 Patrick Welche 2009-03-02 17:14:03 UTC
Fixed - thanks for the report.