GNOME Bugzilla – Bug 565780
Message view is tightly packed and hard to read
Last modified: 2009-11-17 08:52:27 UTC
The message view is currently a bit too tightly packed, making it a bit hard to read. Especially compared to apps like Banshee [1] A bit more padding would also make the message view look a bit more attractive. 1. http://download.banshee-project.org/shots/1.4.1/android-purchased-music.png
Created attachment 125382 [details] current spacing
Created attachment 125383 [details] proposed spacing
How much padding did you use in the mockup? Looks like maybe 2 or 3 px on the top and bottom?
Created attachment 125410 [details] [review] Proposed patch Increased the top and bottom padding in ECellText from 1 to 3.
Created attachment 125411 [details] Patch in action Screenshot is of the kill-bonobo branch just because that was more convenient, but I haven't touched ETable on the branch. Patch applies cleanly to trunk.
I should also mention this patch affects ALL ETables, not just the message list. That includes memo and task lists, and list view for contacts and calendars.
Woohoo! Sweet! Comparing the screenshot in #1 with #5 it seems Banshee use a padding of 4 instead of 3. Apart from that, it's perfect!
Confirmed, GtkTreeView is using a padding of 4. Will adjust the patch. Srini, any objections?
Matthew, it looks great. But, just one thing, I don't want people to come back to say it was better before. I would suggest that you make this packing bit adjustable gconf/getenv or something. I remember, the Folder tree was e-trable and we moved to GtkTable and Dave (dave_largo) still complains that it takes too much space :-)
Created attachment 126045 [details] [review] Revised patch Very well. Best solution would be a GtkStyle property, but I don't think even GtkTreeView supports such a property. It's not worth another GConf key so I guess we'll make a secret environment variable for it: ETABLE_PACKED This time the padding value is 4, and I verified the table rows line up perfectly with other applications like Rhythmbox and Nautilus.
Ping: Is the environment variable solution acceptable?
Matt, I still prefer if it is a static var, picked from gconf once. Reason: Gconf is much easier to set and forget for ever than env. Just my preference. But be prepared to get comments on this from more *real* users.
Matt, lets close this. If you think, not worth it, ignore my comment.
I don't know. I guess don't see why we should have to make concessions just for making a custom widget more closely resemble a standard widget. If there's a huge outcry over it, I'd rather add a GtkStyle property and let the dissenters write their own ~/.gtkrc to override the padding. It -should- be hard to revert.
Fine to me. Go ahead then
Committed the original patch (with padding=4). Let the backlash begin! http://git.gnome.org/cgit/evolution/commit/?id=ce11d292c5487743d0543dd998cfd26b8afd0827
Voting for configurability, a GtkStyle property would be ideal. I understand the need for consistent look with GtkTreeView however I still find the old layout optimal for my work (I spend several hours beneath the e-mail client every day). Even with large 24" monitor I prefer small fonts and as much information displayed as possible. For the moment, I've reverted the patch on my machines and recompiled the packages.
It should just be adhering to GtkTreeView::vertical-separator. Cf. my bug #590127 which complains about the lack of consistency with the folder list.