GNOME Bugzilla – Bug 565670
recycling of gtk.CellRendererText()
Last modified: 2009-03-10 14:25:28 UTC
Please describe the problem: Happy Christmas :) According to: http://www.moeraki.com/pygtkreference/pygtk2reference/class-gtkcellrenderer.html just before the "methods" (heading at level 2) "The primary use of a gtk.CellRenderer is for drawing a certain graphical elements on a gtk.gdk.Drawable. Typically, one cell renderer is used to draw many cells on the screen. To this extent, it isn't expected that a CellRenderer keep any permanent state around. Instead, any state is set just prior to use using the GObjects property system. Then, the cell is measured using the get_size() method. Finally, the cell is rendered in the correct location using the render() method." replacing 10 instances by a reference. patch to be attached. Thank you Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 125326 [details] [review] replacing instances by ref promised patch.
Created attachment 125784 [details] [review] Pylinted patch Here's a pylinted version of the patch. Many thanks for providing the original patch! I'm going to put this in just for trunk and not gnome-2-24 -- it seems like it provides a performance improvement for the preferences GUI only, so I don't believe the overall user benefit is great enough for GNOME 2.24. If you disagree, though, please let me know and I can check it in to gnome-2-24 after it's soaked this week.