After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 564313 - Applet slider not instantaneous
Applet slider not instantaneous
Status: RESOLVED FIXED
Product: gnome-media
Classification: Deprecated
Component: gnome-volume-control
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome media maintainers
gnome media maintainers
Depends on:
Blocks:
 
 
Reported: 2008-12-12 21:16 UTC by Bastien Nocera
Modified: 2009-03-12 10:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gvc-instant-volume-change.patch (3.08 KB, patch)
2009-01-12 15:55 UTC, Bastien Nocera
none Details | Review
gvc-fix-zero-adj-usage.patch (5.44 KB, patch)
2009-03-11 12:06 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2008-12-12 21:16:01 UTC
The slider only updates the volume when released. It would be better if it updated on-the-fly. A bit of work might be needed not to flood PA with requests though.
Comment 1 William Jon McCann 2008-12-12 21:23:20 UTC
Maybe.  I tried it and didn't like it.  We also probably want to have it "ping" when the volume changes and that only makes sense if it is discontinuous.

We can try it again I guess.
Comment 2 Bastien Nocera 2008-12-12 21:41:05 UTC
You could only have it ping when you release the slider. I think instantaneous would be fine as long as the slider doesn't lag.
Comment 3 William Jon McCann 2008-12-15 15:01:12 UTC
Yeah, I think you are right.  We should:
 * make it change right away
 * throttle the change events
 * make sure we don't try to set the position of the slider when the user is manipulating it
 * make sure it doesn't lag
 * make it "ping" when the slider is released
Comment 4 Bastien Nocera 2009-01-12 15:55:31 UTC
Created attachment 126287 [details] [review]
gvc-instant-volume-change.patch

This seemed to work fine for me.
Comment 5 Bastien Nocera 2009-01-12 15:57:35 UTC
I used this one-liner to change the volume while I was changing it in the applet:
sleep 5 ; echo "set-sink-volume 0 50000" | pacmd
Comment 6 William Jon McCann 2009-01-16 17:22:11 UTC
Seems to work for me too.  Committed to trunk.  Thanks!
Comment 7 Bastien Nocera 2009-03-11 11:33:50 UTC
This is broken. See https://bugzilla.redhat.com/show_bug.cgi?id=485979#c7

I believe the scroll code is broken too.
Comment 8 Bastien Nocera 2009-03-11 12:06:55 UTC
Created attachment 130460 [details] [review]
gvc-fix-zero-adj-usage.patch

Fixes use of zero_adjustment. Makes drag/release work and unmute as required, and fixes the same problems in the wheel scroll (both on the scale in the applet, and the applet icon itself).
Comment 9 Bastien Nocera 2009-03-12 10:54:23 UTC
2009-03-12  Bastien Nocera  <hadess@hadess.net>

        * src/gvc-balance-bar.c (_scale_box_new),
        (gvc_balance_bar_set_balance_type), (gvc_balance_bar_set_property),
        (gvc_balance_bar_class_init), (on_adjustment_value_changed),
        (gvc_balance_bar_init), (gvc_balance_bar_new): Fix use of the 
        zero_adjustment GtkAdjustment in slider callbacks, export
        gvc_channel_bar_scroll
        * src/gvc-balance-bar.h: Export gvc_channel_bar_scroll

        * src/gvc-stream-status-icon.c (on_status_icon_scroll_event):
        Use gvc_channel_bar_scroll instead of our own code

        (Closes: #564313)