GNOME Bugzilla – Bug 564128
provide menu item and/or button to cancel a build or find
Last modified: 2009-04-06 08:05:16 UTC
Currently, if a build or find files operation is in progress, the only way I can cancel it is to right-click in the Messages view and choose Cancel Command. This is slightly awkward and is hard for users to discover. It would be nice if we additionally provided either (a) a menu item for cancelling a build/find (perhaps with an associated shortcut key such as Ctrl+Break) or (b) a cancel button that appears in the side of the Messages view when an operation is in progress. Other information:
Well, the Find & Replace dialog actually has a Stop button, so this feature request really just applies to stopping a build.
Created attachment 131870 [details] [review] patch for this bug
(In reply to comment #2) > Created an attachment (id=131870) [edit] > patch for this bug I don't like that patch too much. Stopping all builds is not what you usually want. I would rather automatically stop the build when you close the message pane of the build output. In addition, we need some kind of status indication for running builds (something moving in the message view title),
(In reply to comment #3) > I don't like that patch too much. Stopping all builds is not what you usually > want. I would rather automatically stop the build when you close the message > pane of the build output. this feature is already implemented. > In addition, we need some kind of status indication for running builds > (something moving in the message view title), Should message indicate stage (configure, make, complete) or something else?
> this feature is already implemented. No, it doesn't stop the launcher at the moment but I chance that currently. > > In addition, we need some kind of status indication for running builds > > (something moving in the message view title), > Should message indicate stage (configure, make, complete) or something else? I would like some animation of the message-view icon while a build is running (something like what network-manager does in the notification area when waiting for dhcp).
>(In reply to comment #4) > > In addition, we need some kind of status indication for running builds > > (something moving in the message view title), >Should message indicate stage (configure, make, complete) or something else? I don't think we need such these details, something moving when the build is running will be perfect. But I think the really important things is to have something different when the build is running and when it is completed with a different icon if there are errors or warnings.
Created attachment 131998 [details] [review] This patch sets the message view title to the current status of a build. This patch was against the anjuta-2.26.0.0-tar-bz2 stable release.
> I would like some animation of the message-view icon while a build is running > (something like what network-manager does in the notification area when waiting > for dhcp). If I am not mistaken, to have an animated icon while build is in progress might require us to have a new thread that keeps changing the icon continuosly (so as to have a sense of animation). Is that the correct approach to go ahead with?
> If I am not mistaken, to have an animated icon while build is in progress might > require us to have a new thread that keeps changing the icon continuosly (so as > to have a sense of animation). Is that the correct approach to go ahead with? No, gdk_pixbuf_set_from_animation is your friend here. The glib mainloop will take care of displaying the animation correctly. About the patch: - Never hardcode string arrays - use something like g_strdup_printf() instead - Mind the style (no "var=x" but instead "var = x") - In general I don't like displaying the status as it makes the tab unnecessary long. Use an animation on top of the icon instead.
Created attachment 132003 [details] [review] Kills the build's launcher when message view is closed by user.
Created attachment 132006 [details] [review] Kills the build's launcher when message view is closed by user. [Please ignore previous patch, sorry]
Some lines below there is a check if (launcher == NULL) which would be a better place to add an else branch (or simply do something regardless but set launcher = NULL in the end. BTW, please makes patches against svn trunk (actually that's one of the points why we want patches - to find out if you can use the version control system correctly).
Created attachment 132009 [details] [review] patch for this bug I add animation("process-working") while a build is running. Now message-view has different icon for completed with error("GTK_STOCK_STOP"), completed successfully("GTK_STOCK_APPLY").
The patch looks good - I will have a closer look on sunday - thanks!
*** Bug 577441 has been marked as a duplicate of this bug. ***
Thanks for patch. I made some small adjustments (icon size should be GTK_ICON_SIZE_MENU, set the animation when the message tab is reused, fixed some warnings, kill build when message tab is destroyed). Please check for all warnings next time, they ARE important. Thanks!