GNOME Bugzilla – Bug 563956
The xml comment files do not load anymore.
Last modified: 2008-12-19 09:27:56 UTC
When viewing an image that has an associated xml comments file (and not "internal" metadata), no comments are displayed at all. This is due to passing an uri to the path_exists() function , which accepts only filenames.
Created attachment 124332 [details] [review] Convert the uri to a regular filename, before testing whether the file exists.
Hmm... something is still very broken. Setting/editing comments on a tif file doesn't work, for example... This needs further investigation. - Mike
Created attachment 124891 [details] [review] fix comment reading/writing Jef, Can you test this patch? There is still a problem changing comments in odd file types that we can read metadata from, but not write to, like an ORF raw file. I'm not sure there is an elegant fix for that. The existing code gived priority to the metadata rather than the xml - but if the metadata is read-only, the comments are not editable... - Mike
I've committed my patch, marking as fixed. - Mike
I never noticed the problem with the read-only embedded metadata, because I don't have such files. The patch seems to work fine. I won't be surprised there will be other similar bugs, due to this uri vs raw filename difference. I think all those problems will be solved when porting gthumb to gio/gvfs is finished (bug 525482). Implementing a fallback to using the xml comment file, when writing the embedded metadata fails is not really an option. First of all, a user will expect the embedded metadata is updated, while only the xml comment file will actually be updated. And last but not least, when reading the metadata later again, the (not updated) embedded metadata would take priority and the change will appear lost. Maybe we could use file timestamps to pick which metadata (embedded vs xml) should take priority? Anyway, this is stuff for a new bug. Also related to bug 533819.