After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 563788 - GNOME Goal: Clean up GLib and GTK+ includes
GNOME Goal: Clean up GLib and GTK+ includes
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: general
git master
Other Linux
: Normal trivial
: ---
Assigned To: gvfs-maint
gvfs-maint
: 561351 (view as bug list)
Depends on:
Blocks: 563413
 
 
Reported: 2008-12-09 00:44 UTC by Luis Menina
Modified: 2009-10-09 20:37 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
simple patch (2.90 KB, patch)
2008-12-09 00:46 UTC, Luis Menina 		none Details | Review
updated patch (2.65 KB, patch)
2008-12-21 00:29 UTC, Luis Menina 		committed Details | Review

Description Luis Menina 2008-12-09 00:44:47 UTC 
Correct applications or libraries that don't include
*only* toplevel headers for GLib, GTK, GDK and gdk-pixbuf. This will be useful
to prepare GTK 3.0 migration.

See also http://live.gnome.org/GnomeGoals/CleanupGTKIncludes
Comment 1 Luis Menina 2008-12-09 00:46:46 UTC 
Created attachment 124224 [details] [review]
simple patch
Comment 2 Luis Menina 2008-12-21 00:29:57 UTC 
Created attachment 125069 [details] [review]
updated patch

please apply ASAP...
Comment 3 Luis Menina 2009-01-08 00:57:41 UTC 
ping...
Comment 4 Matthias Clasen 2009-01-10 03:42:17 UTC 
Looks fine to me.
Comment 5 André Klapper 2009-01-25 21:23:35 UTC 
Luis: Can you commit this, please?
Comment 6 Luis Menina 2009-01-26 01:13:17 UTC 
Sorry Andre, I don't have commit rights.
Comment 7 Bastien Nocera 2009-02-05 14:02:29 UTC 
2009-02-05  Bastien Nocera  <hadess@hadess.net>

        Bug 563788 – GNOME Goal: Clean up GLib and GTK+ includes

        * client/gvfsuriutils.h:
        * daemon/gvfsbackendburn.c:
        * daemon/gvfsbackendcomputer.c:
        * daemon/gvfsbackenddnssd.c:
        * daemon/gvfsbackendnetwork.c:
        * daemon/gvfsdaemonutils.c:
        * daemon/mount.c: Fix build for single GTK+ include, patch
        from Luis Menina <liberforce@freeside.fr> (Closes: #563788)
Comment 8 Christian Kellner 2009-10-09 20:37:38 UTC 
*** Bug 561351 has been marked as a duplicate of this bug. ***