Created attachment 124039 [details] [review]
Add full size icon+title to overlay

The icon+text is useful in order to distinguish between windows
that might look similar otherwise.

The implementation is not optimal:

* We create a new texture from the pixmap each time
* The hide() code treats the titles as windows

This patch isn't perfect, there are other bugs besides the above like icons not sized properly, but I think it's a good discussion starting point.  So, ready...set...DISCUSS!

Looks nice to me (I've only tried with 4 windows on 1 workspace, though). It would look better if you made it semi-transparent and, perhaps, placed it centered at the bottom, though.

Also:
< owen> +const GtkClutter = imports.gi.GtkClutter;
< owen> Looks like deleting it shoudl be fine, it's stray

(In reply to comment #1)
> -                let win = wswindows[i];
> +                let win = wswindows[i]

that's obviously wrong

Also, you need to make the labels disappear when hiding the overlay; currently they all go to 0,0.

The UI could use some work, but that's true of most of the interface at this point, so that's not a point against it. So I'd say fix hiding and commit it.

Created attachment 124809 [details] [review]
Add full size icon+title to overlay

The icon+text is useful in order to distinguish between windows
that might look similar otherwise.

The implementation is not optimal:

* We create a new texture from the pixmap each time

looks ok. maybe add something to http://live.gnome.org/GnomeShell/Todo about making it prettier?

Slightly prettier now, but I added something to TODO as suggested.

Committed r129
	M	js/ui/workspaces.js
r129 = 81fab356b2c6f0ff57a22d98c205cbe436aa67c6 (git-svn)

This bug is absolutely NOT FIXED.

To me this tweak is completely necessary to distinguish between windows in shell overview, which, at present, is more than tricky.

Please, reopen the bug, fix it, because life's hard with the current implementation.

You replied to an eight year old ticket. 
If there is some problem nowadays, please file a new ticket. Thanks!

*After* this bug was closed, there was a design decision to remove the icons added here again. This bug is definitively the wrong place to complain about the decision - bug 634599 is likely what you are looking for, though every argument has probably been brought up a million times already ...