After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 562900 - gnome power manager keeps using xrandr backend after failed calls
gnome power manager keeps using xrandr backend after failed calls
Status: RESOLVED FIXED
Product: gnome-power-manager
Classification: Deprecated
Component: gnome-power-manager
2.24.x
Other All
: Normal normal
: ---
Assigned To: GNOME Power Manager Maintainer(s)
GNOME Power Manager Maintainer(s)
: 552762 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-12-01 19:51 UTC by Mario Limonciello
Modified: 2009-03-02 10:43 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
Patch to fallback to HAL backend if XRANDR calls fail (2.98 KB, patch)
2008-12-01 19:52 UTC, Mario Limonciello
none Details | Review
Patch to fallback to HAL backend if XRANDR calls fail (3.47 KB, patch)
2008-12-01 20:07 UTC, Mario Limonciello
none Details | Review

Description Mario Limonciello 2008-12-01 19:51:32 UTC
Please describe the problem:
Currently, several Dell laptops contain Intel graphics cards.  The Intel driver reports that it is able to change the display brightness, however it also reports the number of levels supported is zero.

In cases such as these, gnome power manager should fallback to the functional HAL Backend if it's available for the laptop.

Steps to reproduce:
1. Try to change brightness on a laptop that:
 a. Reports xrandr is supported
 b. Reports zero possible levels
 c. Does not use ACPI for changing levels
 d. Supports a HAL backend


Actual results:
No brightness change in the OSD when using hardware controls.
No brightness change with software controls

Expected results:
Brightness should be changeable using software controls

Does this happen every time?
Yes

Other information:
Comment 1 Mario Limonciello 2008-12-01 19:52:12 UTC
Created attachment 123753 [details] [review]
Patch to fallback to HAL backend if XRANDR calls fail
Comment 2 Mario Limonciello 2008-12-01 20:07:37 UTC
Created attachment 123756 [details] [review]
Patch to fallback to HAL backend if XRANDR calls fail
Comment 3 Richard Hughes 2008-12-02 09:05:50 UTC
Applied to 2-24 and trunk, many thanks.

2008-12-02  Richard Hughes  <richard@hughsie.com>

	* src/gpm-brightness-xrandr.c:
	(gpm_brightness_xrandr_output_get_percentage),
	(gpm_brightness_xrandr_output_down),
	(gpm_brightness_xrandr_output_up),
	(gpm_brightness_xrandr_output_set):
	* src/gpm-brightness.c: (gpm_brightness_set), (gpm_brightness_get),
	(gpm_brightness_up), (gpm_brightness_down), (gpm_brightness_init):
	Currently, several Dell laptops contain Intel graphics cards.
	The Intel driver reports that it is able to change the display
	brightness, however it also reports the number of levels supported
	as zero.
	In cases such as these, gnome power manager should fallback to the
	functional HAL Backend if it's available for the laptop.
	Fixes #562900

	Patch from Mario Limonciello <mario_limonciello@dell.com>, and slightly
	modified by me. Many thanks.
Comment 4 Wang Xin 2009-03-02 10:43:06 UTC
*** Bug 552762 has been marked as a duplicate of this bug. ***