GNOME Bugzilla – Bug 562462
"Open new chats in separate windows" has no obvious opposite
Last modified: 2012-01-27 10:18:55 UTC
Empathy 2.24.1, Ubuntu 8.10 In the Preferences "General" tab, the "Behaviour" section has a checkbox labelled "Open new chats in separate windows". Guideline: Use a checkbox only if the label for the checked state makes obvious the meaning of the unchecked state. It's not obvious what it means for "Open new chats in separate windows" to be unchecked. How else would they be shown? One way of solving this would be to present the option as a pair of radio buttons: Open chats in: (*) separate windows ( ) tabs
Make sense.
My branch here [1] has a fix for this [1] http://git.collabora.co.uk/?p=user/cosimoc/empathy.git;a=shortlog;h=refs/heads/separate_windows
Please attach a patch if you don't want to see you branch lost if the tons of opened bugs. :)
Created attachment 206149 [details] [review] recovered from depths of Collabora's git archive
Created attachment 206240 [details] [review] preferences: split "Open new chats in separate windows" into a radiobutton Old patch was from dawn of time and not rebasable. http://cgit.collabora.com/git/user/danni/empathy.git/commit/?h=trivia&id=a8fbf027f0f8b2c4aa343db7c81f23c49ac4d3e5
Attachment 206240 [details] pushed as a8fbf02 - preferences: split "Open new chats in separate windows" into a radiobutton