After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 562065 - mpeg2dec does not handle STATE_SEQUENCE_MODIFIED from >=libmpeg-0.5.0
mpeg2dec does not handle STATE_SEQUENCE_MODIFIED from >=libmpeg-0.5.0
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other All
: Normal normal
: 0.10.11
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-11-23 23:00 UTC by Simon Holm Thøgersen
Modified: 2008-11-24 09:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mpeg2dec: add support for STATE_SEQUENCE_MODIFIED (1.30 KB, patch)
2008-11-23 23:29 UTC, Simon Holm Thøgersen 		committed Details | Review

Description Simon Holm Thøgersen 2008-11-23 23:00:45 UTC 
Please describe the problem:
I get the following error trying to access the Setup menu of my 1492: Conquest of Paradise dvd (by way of resindvd and Totem):

gstmpeg2dec.c:1165:gst_mpeg2dec_chain:<mpeg2dec2> Unknown libmpeg2 state 11, FIXME

State 11 is STATE_SEQUENCE_MODIFIED that was added to libmpeg2 in version 0.5.0. It seems to be a slight variation of STATE_SEQUENCE and STATE_SEQUENCE_REPEATED and I'll attach a patch that solves the issue for me, though I'm not completely convinced it is correct in all cases.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Simon Holm Thøgersen 2008-11-23 23:05:28 UTC 
I'm taking the liberty to add Jan Schmidt to the CC list as this issue was found evaluating resindvd that he wrote.
Comment 2 Simon Holm Thøgersen 2008-11-23 23:29:18 UTC 
Created attachment 123289 [details] [review]
mpeg2dec: add support for STATE_SEQUENCE_MODIFIED
Comment 3 Sebastian Dröge (slomo) 2008-11-24 09:51:28 UTC 
2008-11-24  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

        Patch by: Simon Holm Thøgersen <odie at cs dot aau dot dk>

        * ext/mpeg2dec/gstmpeg2dec.c: (gst_mpeg2dec_chain):
        Add support for the STATE_SEQUENCE_MODIFIED state in mpeg2dec
        >= 0.5.0. Fixes bug #562065.