After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 561989 - Signals for GType based fundanmental classes.
Signals for GType based fundanmental classes.
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Objects
0.5.x
Other All
: Normal normal
: ---
Assigned To: Jürg Billeter
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2008-11-23 09:42 UTC by rainwoodman
Modified: 2008-12-01 07:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Signals for GType based classes (5.12 KB, patch)
2008-11-23 09:43 UTC, rainwoodman 		committed Details | Review

Description rainwoodman 2008-11-23 09:42:30 UTC 
Please describe the problem:
GSignal system doesn't specifically require signals to be binded with GObject derivatives.

See: http://library.gnome.org/devel/gobject/unstable/gobject-Signals.html#id3198916

This patch enables signals in vala's GType based fundanmental classes.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
It also fixed a bug in type_collect function which causes g_value_set_instance to fail. (and therefore the g_signal_emit also fails).
Comment 1 rainwoodman 2008-11-23 09:43:52 UTC 
Created attachment 123257 [details] [review]
Signals for GType based classes
Comment 2 rainwoodman 2008-11-23 23:39:29 UTC 
I would suggest this patch and Bug 562070 to be merged upstream together.
Comment 3 Jürg Billeter 2008-12-01 07:58:08 UTC 
2008-12-01  Jürg Billeter  <j@bitron.ch>

	* gobject/valagobjectmodule.vala:
	* gobject/valagsignalmodule.vala:

	Support signals in non-GObject classes, patch by Yu Feng,
	fixes bug 561989

Fixed in r2108.