After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 561881 - Add fingerprint enrollment support
Add fingerprint enrollment support
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] about-me
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-11-22 00:47 UTC by Bastien Nocera
Modified: 2008-11-27 22:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gcc-about-me-fprintd-1.patch (42.08 KB, patch)
2008-11-26 18:26 UTC, Bastien Nocera
needs-work Details | Review
Deleting existing fingerprints (37.76 KB, image/png)
2008-11-26 18:30 UTC, Bastien Nocera
  Details
Finger selection page (20.65 KB, image/png)
2008-11-26 18:31 UTC, Bastien Nocera
  Details
enrollment page, not enrolled yet (17.97 KB, image/png)
2008-11-26 18:32 UTC, Bastien Nocera
  Details
Enrollment page, enrollment done (17.85 KB, image/png)
2008-11-26 18:32 UTC, Bastien Nocera
  Details
last page (8.03 KB, image/png)
2008-11-26 18:33 UTC, Bastien Nocera
  Details
gcc-about-me-fprintd-2.patch (45.43 KB, patch)
2008-11-27 19:45 UTC, Bastien Nocera
none Details | Review

Description Bastien Nocera 2008-11-22 00:47:04 UTC
Should use fprintd:
http://www.reactivated.net/fprint/wiki/Fprintd
http://hadess.fedorapeople.org/fprintd/docs/

I've already got some code done, just need the actual enrollment bits.
Comment 1 Bastien Nocera 2008-11-26 18:26:42 UTC
Created attachment 123473 [details] [review]
gcc-about-me-fprintd-1.patch

Really ugly first version. Screenshots coming in a minute.
Comment 2 Bastien Nocera 2008-11-26 18:30:01 UTC
Created attachment 123474 [details]
Deleting existing fingerprints
Comment 3 Bastien Nocera 2008-11-26 18:31:16 UTC
Created attachment 123475 [details]
Finger selection page

The assistant to enroll new fingerprints.
Comment 4 Bastien Nocera 2008-11-26 18:32:02 UTC
Created attachment 123476 [details]
enrollment page, not enrolled yet
Comment 5 Bastien Nocera 2008-11-26 18:32:41 UTC
Created attachment 123477 [details]
Enrollment page, enrollment done
Comment 6 Bastien Nocera 2008-11-26 18:33:14 UTC
Created attachment 123478 [details]
last page
Comment 7 Bastien Nocera 2008-11-27 19:45:44 UTC
Created attachment 123568 [details] [review]
gcc-about-me-fprintd-2.patch

Apart from a couple of TODOs (and some uncleanliness in some parts), I'd like to commit this so it's a bit easier to maneuver around the code, and test it on different machines.
Comment 8 Jens Granseuer 2008-11-27 20:52:42 UTC
It looks like you intend to make PolicyKit optional, but in configure it isn't. Please do that before committing.
Comment 9 Bastien Nocera 2008-11-27 21:02:25 UTC
(In reply to comment #8)
> It looks like you intend to make PolicyKit optional, but in configure it isn't.
> Please do that before committing.

Huh, it is. It's the same check as for libebook-1.2. PKG_CHECK_MODULES() will not fail if passed 3 or 4 arguments, as opposed to just 2.
Comment 10 Jens Granseuer 2008-11-27 21:42:34 UTC
(In reply to comment #9)
> Huh, it is. It's the same check as for libebook-1.2. PKG_CHECK_MODULES() will
> not fail if passed 3 or 4 arguments, as opposed to just 2.

No, it's not. You need to pass 4 args instead of the 3 you're passing to do that. And libebook isn't optional.
Comment 11 Bastien Nocera 2008-11-27 22:14:59 UTC
Filed bug 562504 for what's still to do.

2008-11-27  Bastien Nocera  <hadess@hadess.net>

        * configure.in: Optionally check for PolicyKit

2008-11-27  Bastien Nocera  <hadess@hadess.net>

        * Makefile.am:
        * fingerprint-strings.h:
        * fprintd-marshal.list:
        * gnome-about-me-fingerprint.c:
        * gnome-about-me-fingerprint.glade:
        * gnome-about-me-fingerprint.h:
        * gnome-about-me.c (create_fingerprint_button),
        (about_me_load_info), (about_me_fingerprint_button_clicked_cb),
        (about_me_setup_dialog), (main):
        * gnome-about-me.glade: Add support for enrolling fingerprints
        using the fprintd D-Bus service (Closes: #561881)

2008-11-27  Bastien Nocera  <hadess@hadess.net>

        * POTFILES.in: Add new files from the fingerprint
        enrollment support