After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 561161 - [sidplay] Uses GST_CFLAGS for C++
[sidplay] Uses GST_CFLAGS for C++
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other Linux
: Normal blocker
: 0.10.10
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-11-17 07:04 UTC by Sebastian Dröge (slomo)
Modified: 2008-11-17 09:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
sidplay-cxxflags.diff (856 bytes, patch)
2008-11-17 07:04 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2008-11-17 07:04:06 UTC 
Hi,
sidplay currently uses GST_CFLAGS for C++ code. This can break as some CFLAGS are only valid for C and not C++.

Attached patch fixes this by using GST_CXXFLAGS instead
Comment 1 Sebastian Dröge (slomo) 2008-11-17 07:04:42 UTC 
Created attachment 122834 [details] [review]
sidplay-cxxflags.diff
Comment 2 Sebastian Dröge (slomo) 2008-11-17 09:53:42 UTC 
2008-11-17  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

        * ext/sidplay/Makefile.am:
        Use GST_CXXFLAGS for C++ code instead of GST_CFLAGS. The latter could
        contain CFLAGS that do not exist for C++, like -Wvla or
        -Wdeclaration-after-statement. Fixes bug #561161.