Created attachment 122781 [details] [review]
get rid of gnome-open in vino

We already check for GTK 2.13.1 in configure.in, so we can use gtk_show_uri.

Thus, we don't need to check for GTK 2.13.1 in vino-status-icon.c in a couple of places, since it will be available.

vino_status_icon_help now calls gtk_show_uri, and in case of error, calls vino_status_icon_spawn_on_error to display an error dialog

vino_status_icon_preferences now launches vino-preferences, and in case of error, calls vino_status_icon_spawn_on_error to display an error dialog

since nothing is using vino_status_icon_spawn_command now, I've converted it to vino_status_icon_spawn_on_error which displays an error dialog

The patch works for me with Vino 2.24.1, and applies to trunk. Please review :)

Hi, Emilio.

Thanks for your patch. I've committed it with some changes. See rev 1008: http://svn.gnome.org/viewvc/vino?view=revision&sortby=date&revision=1008

Some tips:
1) GError structure should be passed as reference: &error. You should have seen this in a gcc warning. Pay attention on gcc warnings :)
2) Try to test your patch, for example, making uri to gtk_show_uri invalid. Thus you could see the error dialog in action.

Welcome aboard :)

Cool! And thanks for the tips!