GNOME Bugzilla – Bug 560886
Now Playing displays previous and current artist if current song has no album.
Last modified: 2009-03-26 01:34:18 UTC
Please describe the problem: When the current song doesn't have an album, (not even "Unknown") Now Playing displays the previous song's artist above the current song's artist. Steps to reproduce: 1. Listen to a song with an album. 2. List to one without one. 3. Go to Now Playing. (I don't know if switching 2 and 3 makes a difference. I forgot which one I did. :) Actual results: Expected results: Does this happen every time? Other information: In case it's relevant, both songs were playing from Last.fm. Album-less songs don't appear too often from Last.fm, so I couldn't test it again. The next song with an album is displayed correctly.
Created attachment 122711 [details] screenshot The previous song (with an album) was by The Maccabees and the current song (without an album) is I've Seen Enough by Cold War Kids. Thanks.
Created attachment 131066 [details] [review] Check the track info string for enough spans before splitting LargeTrackDisplayInfo does some very weird stuff to get the lines for display, apparently to work around translation-related code in the generic track info widget. Therefore, rather than fix the underlying problem, this will just sort of plaster it over. Patch: When splitting the info line on <span>, check that there are at least three <span>s before splitting.
Looks good, thanks John.