After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 560819 - Remove obsolete backends
Remove obsolete backends
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks: vte1.0
 
 
Reported: 2008-11-14 16:00 UTC by Behdad Esfahbod
Modified: 2008-11-20 18:15 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Behdad Esfahbod 2008-11-14 16:00:50 UTC
Everything but xft and pangocairo must die.  They are all extremely buggy (except for the pango one which is extremely slow).
Comment 1 Behdad Esfahbod 2008-11-20 16:09:49 UTC
2008-11-20  Behdad Esfahbod  <behdad@gnome.org>

        Bug 560819 – Remove obsolete backends

        * configure.in:
        * src/Makefile.am:
        * src/vtedraw.c:
        * src/vtepangox.c:
        * src/vtepangox.h:
        Remove pangox backend.

Comment 2 Behdad Esfahbod 2008-11-20 16:13:18 UTC
2008-11-20  Behdad Esfahbod  <behdad@gnome.org>

        Bug 560819 – Remove obsolete backends

        * src/Makefile.am:
        * src/vtedraw.c:
        * src/vtepango.c:
        * src/vtepango.h:
        Remove pango backend.

Comment 3 Behdad Esfahbod 2008-11-20 16:47:13 UTC
Actually, I'm removing xft backend too.  It shaves so much code off...  vtefc.c, vteglyph.c, vtergb.c, vterdb.c, all gone.
Comment 4 Behdad Esfahbod 2008-11-20 16:48:10 UTC
2008-11-20  Behdad Esfahbod  <behdad@gnome.org>

        Bug 560819 – Remove obsolete backends

        * configure.in:
        * src/Makefile.am:
        * src/vtebg.c (vte_bg_get_pixmap):
        * src/vtebg.h:
        * src/vtedraw.c:
        * src/vtefc.c:
        * src/vtefc.h:
        * src/vteft2.c:
        * src/vteft2.h:
        * src/vtegl.c:
        * src/vtegl.h:
        * src/vteglyph.c:
        * src/vteglyph.h:
        * src/vterdb.c:
        * src/vterdb.h:
        * src/vtergb.c:
        * src/vtergb.h:
        * src/vtexft.c:
        * src/vtexft.h:
        Remove all backends except for pangocairo.  Saves so much code.

Comment 5 Christian Persch 2008-11-20 18:03:33 UTC
Since there's now only one backend, can we remove the whole backend abstraction too? 
Comment 6 Behdad Esfahbod 2008-11-20 18:06:46 UTC
We talked about it on irc.  There's no immediate benefit and we'd have to merge the debugging code in vtedraw.c into the pangocairo backend.  I'll look into it again later.
Comment 7 Behdad Esfahbod 2008-11-20 18:15:33 UTC
Summary of changes since last week:

 ChangeLog                           |  231 +++++++
 configure.in                        |  197 ------
 doc/reference/tmpl/vte.sgml         |  130 ++++
 gnome-pty-helper/Makefile.am        |    3 
 gnome-pty-helper/configure.in       |   12 
 gnome-pty-helper/gnome-pty-helper.c |   11 
 src/Makefile.am                     |   33 -
 src/vte.c                           |   17 
 src/vtebg.c                         |  106 ---
 src/vtebg.h                         |    5 
 src/vtedraw.c                       |  272 +++++----
 src/vtedraw.h                       |   36 -
 src/vtefc.c                         |  496 -----------------
 src/vtefc.h                         |   48 -
 src/vteft2.c                        |  426 --------------
 src/vteft2.h                        |   33 -
 src/vtegl.c                         |  615 ---------------------
 src/vtegl.h                         |   33 -
 src/vteglyph.c                      |  805 ---------------------------
 src/vteglyph.h                      |   92 ---
 src/vtepango.c                      |  454 ---------------
 src/vtepango.h                      |   33 -
 src/vtepangocairo.c                 |  906 +++++++++++++++++++++++++++++++
 src/vtepangocairo.h                 |   33 +
 src/vtepangox.c                     |  506 -----------------
 src/vtepangox.h                     |   33 -
 src/vterdb.c                        |  273 ---------
 src/vterdb.h                        |   36 -
 src/vtergb.c                        |  283 ---------
 src/vtergb.h                        |   53 -
 src/vteskel.c                       |  199 ------
 src/vtexft.c                        | 1043 ------------------------------------
 src/vtexft.h                        |   37 -
 33 files changed, 1518 insertions(+), 5972 deletions(-)