After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 560681 - Parsing QUOTED-PRINTABLE vcards probably ignores CHARSET info
Parsing QUOTED-PRINTABLE vcards probably ignores CHARSET info
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Contacts
2.22.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Milan Crha
Evolution QA team
: 562209 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-11-13 19:35 UTC by André Klapper
Modified: 2008-11-25 12:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed eds patch (3.33 KB, patch)
2008-11-19 14:26 UTC, Milan Crha
committed Details | Review

Description André Klapper 2008-11-13 19:35:23 UTC
Basic info: QUOTED-PRINTABLE: In ISO-8859-1, ü is =FC. In UTF-8, ü is =C3=BC.
The name in this example is "Günther Smith".

---cut here---
BEGIN:VCARD

VERSION:2.1

FN;CHARSET=UTF-8;ENCODING=QUOTED-PRINTABLE:G=C3=BCnther Smith

N;CHARSET=UTF-8;ENCODING=QUOTED-PRINTABLE:G=C3=BCnther Smith

TEL;CELL:123

X-IRMC-LUID:0002000004D0

END:VCARD

---cut here---


Setting
   FN;CHARSET=UTF-8;QUOTED-PRINTABLE:G=C3=BCnther Smith
or
   FN;CHARSET=UTF-8;ENCODING=QUOTED-PRINTABLE:G=C3=BCnther Smith
works both fine when importing into GNOME Evolution 2.22.3.1.

Setting
   FN;CHARSET=ISO-8859-1;QUOTED-PRINTABLE:G=FCnther Smith
or
   FN;CHARSET=ISO-8859-1;ENCODING=QUOTED-PRINTABLE:G=FCnther Smith
works NOT when importing into GNOME Evolution 2.22.3.1.


So maybe e-d-s simply does not support importing non utf-8 encoded vcards?

Ashish, can you please clarify this, or fix the CHARSET parsing if it's a valid issue? Is it parsed at all I wonder? ;-)

Downstream bug: https://bugs.maemo.org/show_bug.cgi?id=2781
Comment 1 André Klapper 2008-11-19 14:00:56 UTC
http://svn.gnome.org/viewvc/evolution-data-server/trunk/addressbook/libebook/e-vcard.c

<mcrha> it seems EVcard doesn't understand the CHARSET parameter
Comment 2 Milan Crha 2008-11-19 14:26:11 UTC
Created attachment 123036 [details] [review]
proposed eds patch

for evolution-data-server;

Support CHARSET parameter within the attribute and convert text to UTF-8, if necessary, based on its value.
Comment 3 Milan Crha 2008-11-19 14:27:12 UTC
It's a 'probabledup', I believe.
Comment 4 Ross Burton 2008-11-19 14:33:28 UTC
Looks good to me.
Comment 5 André Klapper 2008-11-19 14:53:30 UTC
(In reply to comment #3)
> It's a 'probabledup', I believe.

Yeah, but couldn't find a dup, hence filed this with clear instructions.
Comment 6 Milan Crha 2008-11-19 15:15:31 UTC
Committed to trunk. Committed revision 9774.

(In reply to comment #5)
> (In reply to comment #3)
> Yeah, but couldn't find a dup, hence filed this with clear instructions.

How is it possible, how... :)
Comment 7 Sebastian 2008-11-25 12:50:25 UTC
*** Bug 562209 has been marked as a duplicate of this bug. ***