After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 560678 - Cleaning up GTK Includes in gnome-applets
Cleaning up GTK Includes in gnome-applets
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: general
git master
Other All
: Normal trivial
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on: 563629
Blocks: 563413
 
 
Reported: 2008-11-13 19:16 UTC by Maxim Ermilov
Modified: 2009-06-25 16:10 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
patch for this bug (10.24 KB, patch)
2008-11-13 20:35 UTC, Maxim Ermilov 		committed Details | Review
More complete patch (2.00 KB, patch)
2009-06-11 23:30 UTC, Luis Menina 		committed Details | Review

Description Maxim Ermilov 2008-11-13 19:16:36 UTC 
I'm working on implementing http://live.gnome.org/GnomeGoals/CleanupGTKIncludes

If it's not a good idea, or not currently on the agenda, please let me know.
Otherwise I'll be working on this for now.
Comment 1 Callum McKenzie 2008-11-13 19:20:43 UTC 
Go for it. These cleanups need to be done.
Comment 2 Maxim Ermilov 2008-11-13 20:35:12 UTC 
Created attachment 122598 [details] [review]
patch for this bug
Comment 3 Callum McKenzie 2008-11-14 03:35:24 UTC 
Patch committed, thanks.
Comment 4 Luis Menina 2009-06-11 23:30:50 UTC 
Created attachment 136379 [details] [review]
More complete patch

Fix to compile with -DG_DISABLE_SINGLE_INCLUDES -DGDK_PIXBUF_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_SINGLE_INCLUDES
Comment 5 Callum McKenzie 2009-06-25 09:28:17 UTC 
Looks good, patch committed.

I also fixed up mini-commander, which isn't built by default.

gswitchit applet doesn't pass because libgnomekbd doesn't.