After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 560459 - Cleaning up GTK Includes in gnome-panel
Cleaning up GTK Includes in gnome-panel
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: general
git master
Other All
: Normal enhancement
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks: 563413
 
 
Reported: 2008-11-12 05:10 UTC by Maxim Ermilov
Modified: 2008-12-09 03:13 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
Patch for this bug (15.39 KB, patch)
2008-11-12 06:14 UTC, Maxim Ermilov 		reviewed Details | Review

Description Maxim Ermilov 2008-11-12 05:10:57 UTC 
I'm working on implementing http://live.gnome.org/GnomeGoals/CleanupGTKIncludes

If it's not a good idea, or not currently on the agenda, please let me know.
Otherwise I'll be working on this for now.
Comment 1 Maxim Ermilov 2008-11-12 06:14:06 UTC 
Created attachment 122472 [details] [review]
Patch for this bug
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2008-11-26 15:54:25 UTC 
I think your patch looks good. It's just a matter of applying, check if it still builds and commit.

Vincent? do you agree?
Comment 3 Vincent Untz 2008-12-09 01:16:11 UTC 
Diego: marking a patch as reviewed makes it invisible for me from http://bugzilla.gnome.org/browse.cgi?product=gnome-panel
Comment 4 Diego Escalante Urrelo (not reading bugmail) 2008-12-09 02:49:51 UTC 
Oh, you are right, didn't really think of that...
Comment 5 Vincent Untz 2008-12-09 03:13:17 UTC 
Fixed in trunk.