GNOME Bugzilla – Bug 560436
GNOME Goal: Remove deprecated GLib symbols
Last modified: 2009-06-12 00:56:11 UTC
See http://live.gnome.org/GnomeGoals/RemoveDeprecatedSymbols/Glib Here are the files+lines using deprecated GLib symbols in this module: gnome-media/cddb-slave2/inetaddr.c:559: * g_main_iteration(FALSE) between calls. This will help prevent an gnome-media/cddb-slave2/iochannel.c:35: * basically a wrapper around g_io_channel_write(). The problem with gnome-media/cddb-slave2/iochannel.c:36: * g_io_channel_write() is that it may not write all the bytes in the gnome-media/cddb-slave2/iochannel.c:62: if ((error = g_io_channel_write(channel, ptr, nleft, &nwritten)) gnome-media/cddb-slave2/iochannel.c:91: * This is basically a wrapper around g_io_channel_read(). The gnome-media/cddb-slave2/iochannel.c:92: * problem with g_io_channel_read() is that it may not read all the gnome-media/cddb-slave2/iochannel.c:119: if ((error = g_io_channel_read(channel, ptr, nleft, &nread)) gnome-media/gnome-cd/cdrom.c:109: G_GNUC_FUNCTION, gnome-media/gnome-cd/cdrom.c:124: G_GNUC_FUNCTION, gnome-media/gnome-cd/cdrom.c:140: G_GNUC_FUNCTION, gnome-media/gnome-cd/cdrom.c:159: G_GNUC_FUNCTION, gnome-media/gnome-cd/cdrom.c:174: G_GNUC_FUNCTION, gnome-media/gnome-cd/cdrom.c:189: G_GNUC_FUNCTION, gnome-media/gnome-cd/cdrom.c:204: G_GNUC_FUNCTION, gnome-media/gnome-cd/cdrom.c:219: G_GNUC_FUNCTION, gnome-media/gnome-cd/cdrom.c:235: G_GNUC_FUNCTION, gnome-media/gnome-cd/cdrom.c:251: G_GNUC_FUNCTION, gnome-media/gnome-cd/cdrom.c:267: G_GNUC_FUNCTION, gnome-media/gnome-cd/cdrom.c:283: G_GNUC_FUNCTION, gnome-media/gnome-cd/cdrom.c:299: G_GNUC_FUNCTION, gnome-media/gnome-cd/callbacks.c:151: g_warning ("%s: %s", G_GNUC_FUNCTION, error->message);
Hello Luis! Looks like you could improve your detection script a little bit :)
Is that about the comments ? Well if the comments refer to deprecated functions, they should be changed alike...
The cddb-slave2 module uses a stripped down version of GNet, which uses deprecated symbols. The GNet library currently still uses these symbols and I do not see any mention of the project updating itself to shed these deprecated symbols. Unfortunately, several functions (see iochannel.h) have return values of type GIOError--a type that is not listed as deprecated, yet is implicitly deprecated because it is only used in context of deprecated functions. All this is to say that updating from GIOError to the preferred GIOStatus return type is not going to be a trivial patch, as existing programs relying upon this specification will break. So, does cddb-slave2 extend its stripped-down version to appease the deprecated GLib symbols or does this propagate to the GNet project itself?
Hi there! well, gnome-cd and cddb-slave2 are unmaintained. Will mark as gnome-love :)
Note that gnome-media itsels builds nicely with -DG_DISABLE_DEPRECATED, but replacing those symbols or the concerned modules if they are deprecated would be nice.
(In reply to comment #5) > Note that gnome-media itsels builds nicely with -DG_DISABLE_DEPRECATED, but > replacing those symbols or the concerned modules if they are deprecated would > be nice. If that's the case I'm fine with closing this as FIXED.