After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 560435 - GNOME Goal: Remove deprecated GLib symbols
GNOME Goal: Remove deprecated GLib symbols
Status: RESOLVED FIXED
Product: gnome-nettool
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Germán Poo-Caamaño
Rodrigo Moya
Depends on:
Blocks: 560423
 
 
Reported: 2008-11-12 02:24 UTC by Luis Menina
Modified: 2008-12-04 02:17 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
patch for this bug (634 bytes, patch)
2008-11-22 20:19 UTC, Maxim Ermilov 		committed Details | Review

Description Luis Menina 2008-11-12 02:24:54 UTC 
See http://live.gnome.org/GnomeGoals/RemoveDeprecatedSymbols/Glib
Here are the files+lines using deprecated GLib symbols in this module:

gnome-nettool/src/callbacks.c:236:		if (g_strcasecmp (text, "") != 0)
gnome-nettool/src/callbacks.c:246:		if (g_strcasecmp (text, "") != 0)
Comment 1 Maxim Ermilov 2008-11-22 20:19:33 UTC 
Created attachment 123232 [details] [review]
patch for this bug
Comment 2 Luis Menina 2008-12-03 01:50:35 UTC 
Germán, this patch has a bug: g_strcasecmp does case-insensitive comparisons, and Maxim replaced them with strlen, which is case sensitive. The right thing to do, if the strings to compare are coded in ASCII, is to call g_ascii_strcasecmp.
Comment 3 Luis Menina 2008-12-03 01:54:40 UTC 
Ooops, sorry, I'm mistaken, I read strlen and thought strcmp. The patch is right, even if 
   strlen (text) > 0
could be written 
   *text != '\0'
Comment 4 Germán Poo-Caamaño 2008-12-04 02:17:36 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.