GNOME Bugzilla – Bug 559233
Cleaning up GTK Includes in gedit
Last modified: 2008-12-20 15:42:23 UTC
I'm working on implementing http://live.gnome.org/GnomeGoals/CleanupGTKIncludes If it's not a good idea, or not currently on the agenda, please let me know. Otherwise I'll be working on this for now.
Created attachment 121935 [details] [review] Patch to remove the files included in the top level header files. Any suggestions on how to include headers not included in the toplevel header files?
The patch looks ok at a glance and it's something we'll definitely have to comply with. what do you mean with "headers not included in the toplevel header files"?
I wrote about it http://mail.gnome.org/archives/desktop-devel-list/2008-November/msg00059.html Certain header files, such as glib/gi18n.h and a few others (I'll get the list once I get back to school) are not included in glib.h, for instance. So they will not be added back in if we remove them. It looks like we'll need to make changes to the glib header file in this case? Hopefully that makes sense, please let me know if I can be more descriptive.
Ah you mean gi18n.h etc. No, those headers are fine to keep, they are special purpose header files that should not go in glib.h. If you keep all those special .h and make CFLAGS+="-DG_DISABLE_SINGLE_INCLUDES -DGDK_PIXBUF_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_SINGLE_INCLUDES" compiles, then we are good :)
Alright, I'll work on it and see what happens. Thanks!
I committed the patch in comment 1, thank you. I am closing the bug as fixed, but feel free to reopen if there are still bits that need fixing with regard to single include policy.
Current SVN version still doesn't compile with the special flags.
Created attachment 124205 [details] [review] additional fixes
thanks