GNOME Bugzilla – Bug 559018
Weather service does not add entry if city is selected but "Timezone" field is "Unknown"
Last modified: 2017-12-12 00:54:33 UTC
Please describe the problem: Ubuntu 8.10 gnome-applets 2.24.1-0ubuntu1 It seems that not all the cities listed comes with a timezone attached with it. Some cities such as Paris and New York work fine, they have a timezone attached to them, other cities do not have timezones need to be fixed. Some examples of these are: Arviat, Nunavut Yellowknife, NWT Montreal, Quebec Radisson, Quebec Oral, Kazakhstan Shymkent, Kazakhstan Qyzylorda, Kazakhstan Burwash Landing, Yukon These are a few that I found but there are most likely many more. I think it would be wise to have all of the cities auto-complete this field so that the following does not reproduce itself. It give the impression that the applet is broken when in fact the user has no idea that the timezone field is required to add the entry to the list. Steps to reproduce: Steps to reproduce: 1) Click on the clock panel 2) Beside "Locations" select "Edit" 3) This will open a new window - In the "Locations" tab click "+ Add" 4) Put the name of any of the cities mentioned above 5) Press OK Actual results: What happens: The city is not added regardless of actions taken. No alert is shown. Expected results: What is expected: Either every city should automatically be associated with a Timezone or if this is not technically possible for some reason, prompt the user, or force the user to input the missing mandatory field. Does this happen every time? This happens every time (for selected cities) Other information: Originally posted on: https://bugs.launchpad.net/ubuntu/+source/libgweather/+bug/291853
Most of those missing timezones are bugs. (Eg, all of Quebec is labeled as America/Toronto, so I'm not sure why it's turning up "Unknown".) I cloned this bug to bug 559031 for that part. But the dialog should not pretend to let you add a location and then do nothing; if we can't deal with a location with no time zone (which we probably can't, given that it's the *clock* applet we're talking about), then the "ok"/"add"/whatever button should be disabled.
This issue still exists in GNOME 2.28.0
Created attachment 145187 [details] [review] Patch fixes obselete lookup - Credit for patch: Philippe Gauthier Patch in branch lp:~philippe-gauthier/libgweather/lookup-obsolete-tzid.lp291853 fixes this bug. See https://code.edge.launchpad.net/~philippe-gauthier/libgweather/lookup-obsolete-tzid.lp291853 for more details.
I just uploaded a patch that should apply cleanly to Git HEAD in bug 559031. It is the same code as in the patch in this bug report, but the mismatches due to code added from other patches in "debian/patches" were corrected.
(In reply to komputes from comment #0) > Please describe the problem: > Ubuntu 8.10 > gnome-applets 2.24.1-0ubuntu1 > > It seems that not all the cities listed comes with a timezone attached with > it. Some cities such as Paris and New York work fine, they have a timezone > attached to them, other cities do not have timezones need to be fixed. Some > examples of these are: > > Arviat, Nunavut > Yellowknife, NWT > Montreal, Quebec > Radisson, Quebec > Oral, Kazakhstan > Shymkent, Kazakhstan > Qyzylorda, Kazakhstan > Burwash Landing, Yukon Those all have timezones now, as the bug mentioned in comment 4 has been fixed. > These are a few that I found but there are most likely many more. I think it > would be wise to have all of the cities auto-complete this field so that the > following does not reproduce itself. There's a regression test for this problem since: https://bugzilla.gnome.org/show_bug.cgi?id=791307