GNOME Bugzilla – Bug 558656
Recommendations Pane: Artist color shows up incorrectly with DarkRoom theme
Last modified: 2009-05-13 01:47:47 UTC
Filed downstream: https://bugs.launchpad.net/ubuntu/+source/banshee/+bug/291322. The Recommendations pane artist text shows up incorrectly. See the screenshot: http://launchpadlibrarian.net/19099766/Banshee.png Not sure if there's a Banshee bug here (or just a theme one), but figured I'd file it here in case anything can be done. (I know how much you love working around GTK+ theme bugs.) (Of course, since it's Ubuntu, the theme doesn't seem to be available on its own, but here's the best I can do quickly: http://packages.ubuntu.com/intrepid/human-theme.)
*** Bug 561092 has been marked as a duplicate of this bug. ***
Created attachment 125441 [details] [review] Set foreground to text colour on misbehaving widgets
Comment on attachment 125441 [details] [review] Set foreground to text colour on misbehaving widgets he problem occurs with themes that set different colours for foreground and text. Most themes set foreground and text the same and background and base the same. DarkRoom sets different colours for each of them. The foreground colour contrasts with the background and text contrasts with base. Banshee sets the widgets background colour to the theme's base colour but doesn't set the foreground colour to the theme's text colour.
Hey Chris, thanks for the patch. Please put spaces between method names and arg lists eg likeThis (). See HACKING for our full style guide.
Created attachment 128234 [details] [review] Set foreground to text colour on misbehaving widgets with correct coding style
Thanks Chris, committed.
*** Bug 582377 has been marked as a duplicate of this bug. ***