After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 558418 - Use C_() instead of Q_() with context
Use C_() instead of Q_() with context
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-29 17:01 UTC by Philip Withnall
Modified: 2008-12-08 16:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use C_() instead of Q_() with context (4.33 KB, patch)
2008-10-29 17:02 UTC, Philip Withnall
committed Details | Review

Description Philip Withnall 2008-10-29 17:01:31 UTC
Patch coming up; for http://live.gnome.org/GnomeGoals/MsgctxtMigration.
Comment 1 Philip Withnall 2008-10-29 17:02:53 UTC
Created attachment 121592 [details] [review]
Use C_() instead of Q_() with context
Comment 2 Tommi Vainikainen 2008-10-30 09:40:10 UTC
This patch does not update version dependencies. If patch in current form is applied, if someone tries to compile against too old version of intltool and/or glib, there will be problems with compilation unless intltool and glib version requirements are updated also.
Comment 3 Philip Withnall 2008-10-30 10:08:58 UTC
You're right, I completely forgot about that. The GLib dependency would need bumping to 2.18.0, but the intltool dependency is already high enough.
Comment 4 Vincent Untz 2008-12-08 15:43:55 UTC
Note that when you use NC_(), you should use g_dpgettext2() later on.
Comment 5 Vincent Untz 2008-12-08 15:55:51 UTC
I committed a fixed version. Philip, it might be worth checking that other patches about this don't have the same issue.
Comment 6 Philip Withnall 2008-12-08 16:45:52 UTC
My other patch looks OK in this respect, thankfully. Sorry for the mess.