After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 557784 - [patch] optionally use pangocairo in the pango plugin
[patch] optionally use pangocairo in the pango plugin
Status: RESOLVED DUPLICATE of bug 340887
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-24 15:49 UTC by Guillaume Emont (guijemont)
Modified: 2009-07-30 12:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
The patch (19.75 KB, patch)
2008-10-24 15:55 UTC, Guillaume Emont (guijemont) 		needs-work Details | Review

Description Guillaume Emont (guijemont) 2008-10-24 15:49:04 UTC 
This patch adds the possibility to use pangocairo instead of pangofreetype in the pango plugin.

It basically replaces pangofreetype calls and objects with the pangocairo equivalents, and adds a --with-pangocairo ./configure option.
Comment 1 Guillaume Emont (guijemont) 2008-10-24 15:55:10 UTC 
Created attachment 121286 [details] [review]
The patch
Comment 2 Sebastian Dröge (slomo) 2009-07-17 06:57:20 UTC 
I'm going to commit this after 0.10.24 is released.
Comment 3 Guillaume Emont (guijemont) 2009-07-27 09:58:10 UTC 
Does it still apply cleanly? If not, I can try to refresh it when I find some time.
Comment 4 Tim-Philipp Müller 2009-07-27 10:15:07 UTC 
Why the configure option? Is pangocairo considerably slower? If not, maybe we should just require pangocairo and be done with it? Configure options just add complexity and make stuff harder to maintain and debug.
Comment 5 Guillaume Emont (guijemont) 2009-07-27 11:13:07 UTC 
The reason why I put this configure option in the first place is to avoid adding a strong dependency, but if that's not an issue, I clearly won't fight to keep it.
Comment 6 Sebastian Dröge (slomo) 2009-07-27 15:21:03 UTC 
The patch doesn't apply anymore so it'd be great if you could update it :) Otherwise I'll do it after the releases but that will probably be a bit slower ;)

I'd also suggest to always use pangocairo as it's more portable. pangocairo will always use the native platform font rendering engine IIRC.
Comment 7 Sebastian Dröge (slomo) 2009-07-30 12:38:40 UTC 
*** Bug 340887 has been marked as a duplicate of this bug. ***
Comment 8 Sebastian Dröge (slomo) 2009-07-30 12:41:00 UTC 
Guillaume, bug #340887 contains a patch that does this. I'll close this bug as duplicate of the other one, let's continue everything there.

*** This bug has been marked as a duplicate of 340887 ***

*** This bug has been marked as a duplicate of 340887 ***