After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 557365 - subparse check fails
subparse check fails
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.21
Other Linux
: Normal normal
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-22 08:24 UTC by Götz Waschk
Modified: 2008-12-11 15:49 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
debug output (248.37 KB, text/plain)
2008-10-23 07:31 UTC, Götz Waschk 		  Details
log.bz2 (76.64 KB, application/octet-stream)
2008-12-11 12:47 UTC, Sebastian Dröge (slomo) 		  Details
Force output of last buffer on closure of <sami> tag (1.98 KB, patch)
2008-12-11 15:25 UTC, Edward Hervey 		committed Details | Review

Description Götz Waschk 2008-10-22 08:24:05 UTC 
This is on Mandriva Cooker with gst-plugins-base 0.10.21:

Running suite(s): subparse
93%: Checks: 15, Failures: 1, Errors: 0
elements/subparse.c:241:F:general:test_sami:0: 'g_list_length (buffers)' (1) is not equal to 'num' (2)
FAIL: elements/subparse
Comment 1 Sebastian Dröge (slomo) 2008-10-23 07:15:20 UTC 
Could you run the test with GST_DEBUG=subparse:5 and attach the output to this bug?
Comment 2 Götz Waschk 2008-10-23 07:31:09 UTC 
Created attachment 121181 [details]
debug output
Comment 3 Edward Hervey 2008-12-11 12:36:16 UTC 
Considering that it fails on some setups/machines and not others, there's a good chance this is due to a bug in libxml.
Comment 4 Sebastian Dröge (slomo) 2008-12-11 12:47:09 UTC 
Created attachment 124415 [details]
log.bz2

debug output with GST_DEBUG=5 for a succeeding run of the sami test
Comment 5 Edward Hervey 2008-12-11 15:25:17 UTC 
Created attachment 124428 [details] [review]
Force output of last buffer on closure of <sami> tag

For some reason, some versions of libxml don't properly close all tags, therefore we never get the end_sax_element method called with the final "body" tag, but we do get it for the closing "sami" tag.

The proposed patch basically forces the output of the last buffer on both </body> and </sami>.

Testing and feedback welcome so I commit this ASAP.
Comment 6 Edward Hervey 2008-12-11 15:49:16 UTC 
2008-12-11  Edward Hervey  <edward.hervey@collabora.co.uk>

	* gst/subparse/samiparse.c: (sami_context_push_state),
	(sami_context_pop_state), (start_sami_element), (end_sami_element):
	Some versions of libxml seem to be very picky as to strict formatting
	of the input and never 'close' the final </body> tag.
	In order to fix that bad behaviour, we trigger the flushing of
	remaining data on both </body> and </sami>.
	Fixes #557365