After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 556858 - Network and Disk statistics are misleading - tooltip is corrupting graphs
Network and Disk statistics are misleading - tooltip is corrupting graphs
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: multiload
2.22.x
Other All
: Normal normal
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-18 17:22 UTC by Sylvain Jeaugey
Modified: 2010-06-21 19:51 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
Patch to have network getdata() do a delta only if 1 second has passed (1.43 KB, patch)
2008-10-18 17:25 UTC, Sylvain Jeaugey
none Details | Review
Make disk getdata() do a delta only if 1 second passed. (1.27 KB, patch)
2008-10-18 17:28 UTC, Sylvain Jeaugey
none Details | Review
Patch to fix the bug in correct way (896 bytes, patch)
2010-05-14 18:03 UTC, max ulidtko
none Details | Review

Description Sylvain Jeaugey 2008-10-18 17:22:10 UTC
Please describe the problem:
When the refresh rate is less than 1 second, net and disk activity shows 0 every other line because the glib_top refresh rate is only 1 second. Also, when hovering the mouse on the applet, the getdata function is called, causing the data to be overriden with 0 (since nothing changed - it only changes every second).

So when you move quickly the mouse over the network activity, the reported activity is very often overwritten with 0 (no delta).

Steps to reproduce:
1. Set refresh rate to 500 ms
= or =
2. Move your mouse over the net activity out and in quickly. Activity will drop


Actual results:
Net activity is flawed

Expected results:


Does this happen every time?
Yes

Other information:
Comment 1 Sylvain Jeaugey 2008-10-18 17:25:20 UTC
Created attachment 120834 [details] [review]
Patch to have network getdata() do a delta only if 1 second has passed
Comment 2 Sylvain Jeaugey 2008-10-18 17:28:36 UTC
Created attachment 120835 [details] [review]
Make disk getdata() do a delta only if 1 second passed.

I used 1 second also for disk activity, but I don't really know the sampling rate of this component. Maybe it should be less. Anyway, the "hover-the-mouse-and-corrupt-data" bug is fixed.
Comment 3 Mike Trim 2009-11-16 22:41:50 UTC
I can confirm the bug with the network graph/tooltip referred to in step 2 above.  However I don't experience any problems from setting the refresh rate below 1ms.

(Version 2.28.0-0ubuntu2 of gnome-applets in Ubuntu 9.10/karmic)
Comment 4 max ulidtko 2010-05-14 18:03:49 UTC
Created attachment 161084 [details] [review]
Patch to fix the bug in correct way
Comment 5 Callum McKenzie 2010-06-21 19:51:46 UTC
This has been fixed as part of the fix for bug 617992 (i.e. Max's patch).