After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 556133 - h264parse can't be use in decodebin
h264parse can't be use in decodebin
Status: RESOLVED DUPLICATE of bug 578926
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.8
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-13 13:23 UTC by Benjamin Gaignard
Modified: 2009-07-30 12:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
correction draft (978 bytes, patch)
2008-10-13 13:25 UTC, Benjamin Gaignard 		reviewed Details | Review

Description Benjamin Gaignard 2008-10-13 13:23:17 UTC 
The h264parse doesn't have the correct ranking to be use by decodebin. Following example of mp3parse the caps of sink and source pads should add a boolean to avoid infinite loop in decodebin
Comment 1 Benjamin Gaignard 2008-10-13 13:25:18 UTC 
Created attachment 120499 [details] [review]
correction draft
Comment 2 Benjamin Gaignard 2009-01-23 10:56:53 UTC 
up 
because this not fixed in release 0.10.10
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2009-01-25 16:13:06 UTC 
There are some more things we need to do for h264 caps. Have a look at http://gstreamer.freedesktop.org/wiki/NewCapsFields.
But essentialy this lloks good too.
Comment 4 Sebastian Dröge (slomo) 2009-07-29 13:58:42 UTC 
How much was this tested if it doesn't cause any regressions with one of the possible demuxers before h264parse? Also it might make sense to add parsed=true to the demuxers (if correct) at the same time. Benjamin?

The patch itself is correct of course :)
Comment 5 Benjamin Gaignard 2009-07-29 14:43:16 UTC 
I have tested, since I push the patch, with avidemux and qtdemux on a large set of h264 files and in streaming use case.
Maybe it isn't useful to change ranking while h264parse is in plugins-bad.
Comment 6 Sebastian Dröge (slomo) 2009-07-30 12:27:38 UTC 
Hm, the patch in bug #578926 is a bit better (when setting the srcpad caps it actually sets the parsed field in them). Also that bug has patches for the same issue with mpeg4videoparse. I'm closing this one as a duplicate now :)

*** This bug has been marked as a duplicate of 578926 ***