After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 555916 - drop libglade dependency; use GtkBuilder
drop libglade dependency; use GtkBuilder
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
git master
Other All
: Normal enhancement
: GNOME2.26
Assigned To: Felix Riemann
EOG Maintainers
Depends on:
Blocks: 572883
 
 
Reported: 2008-10-11 15:34 UTC by Felix Riemann
Modified: 2009-02-23 18:24 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
drop libglade and use GtkBuilder instead (132.60 KB, patch)
2008-10-11 15:38 UTC, Felix Riemann 		none Details | Review
the same but without debug spew (132.35 KB, patch)
2008-10-11 16:32 UTC, Felix Riemann 		committed Details | Review

Description Felix Riemann 2008-10-11 15:34:23 UTC 
Title says it all.
EOG has three dialogs that are libglade-created. Converting them to GtkBuilder allows dropping libglade as a dependency which makes one library less to resolve on app start.
Comment 1 Felix Riemann 2008-10-11 15:38:20 UTC 
Created attachment 120382 [details] [review]
drop libglade and use GtkBuilder instead

This makes use of GtkBuilder instead of libglade.
The glade source files are kept in SVN as there is no stable support for editing GtkBuilder-files directly yet. They need to be updated with gtk-builder-convert after changes to the .glade files.
Comment 2 Felix Riemann 2008-10-11 16:32:43 UTC 
Created attachment 120390 [details] [review]
the same but without debug spew
Comment 3 Claudio Saavedra 2008-10-13 17:41:00 UTC 
Patch looks good! Let's get it in right after branching.
Comment 4 Felix Riemann 2008-10-13 19:27:10 UTC 
Rev. 4820:
2008-10-13  Felix Riemann  <>

	* configure.ac:
	* data/Makefile.am:
	* data/eog-image-properties-dialog.ui:
	* data/eog-multiple-save-as-dialog.ui:
	* data/eog-preferences-dialog.ui:
	* src/eog-dialog.c: (eog_dialog_construct_impl),
	(eog_dialog_get_controls):
	* src/eog-plugin-manager.c:
	* src/eog-preferences-dialog.c:
	(eog_preferences_dialog_constructor):
	* src/eog-properties-dialog.c: (eog_properties_dialog_init):
	* src/eog-save-as-dialog-helper.c: (prepare_format_combobox),
	(eog_save_as_dialog_new):
	Drop libglade dependency. Use GtkBuilder instead. The glade files are
	preserved as source for the GtkBuilder files until there is a UI editor
	fully supporting GtkBuilder files. Fixes bug #555916.