After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 555437 - [tag] add GstTagMux base class
[tag] add GstTagMux base class
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-07 18:07 UTC by Emmanuel Rodriguez
Modified: 2011-07-29 18:41 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Emmanuel Rodriguez 2008-10-07 18:07:16 UTC
The plugin good/ext/taglib provides two taggers that are implemented by deriving from  gsttaglibmux. Even though the two taggers implemented by that plugin are using taglib, the plugin skeleton provided by gsttaglibmux is generic enough to be reused by any other tagger, even one using another library than taglib.

This makes taglibmux reusable enough in order to deserve a promotion to go public and to be reused by other plugins.
Comment 1 Tim-Philipp Müller 2009-08-09 00:50:17 UTC
The one in -bad/id3tag/ might actually be better (has support for end tags as well, I think).
Comment 2 Tim-Philipp Müller 2011-07-15 20:02:01 UTC
Current header/API is here:

http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst/id3tag/gsttagmux.h

if anyone wants to have a look. It's only two vfuncs really.
Comment 3 Sebastian Dröge (slomo) 2011-07-27 06:15:35 UTC
The base class looks good but I think the subclasses should add a sink pad template (with maybe non-ANY caps). Other than that it can go into libgsttag IMHO
Comment 4 Tim-Philipp Müller 2011-07-29 18:41:03 UTC
commit e1613349881f7c1dd058b84976912e5086a766cb
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Fri Jul 29 10:23:02 2011 +0100

    Add new GstTagMux base class
    
    Hook up new tag muxing base class to build system.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=555437
    
    API: GstTagMux

commit b83c7e0a0e229c447775a3a17417b65be771241e
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Fri Jul 29 10:22:26 2011 +0100

    docs: add documentation for GstTagMux

commit 2633692072cacff72726ec23cd1cab679cf1b047
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Thu Jul 28 20:38:37 2011 +0100

    tagmux: require subclass to install sink pad template
    
    Require the subclass to install both source and sink pad
    templates. Also, print some warnings if the subclass doesn't
    do that.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=555437