After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 555126 - F-Spot can't export TIFFs to anywhere
F-Spot can't export TIFFs to anywhere
Status: RESOLVED WONTFIX
Product: f-spot
Classification: Other
Component: General
0.5.x
Other All
: Normal normal
: ---
Assigned To: F-spot maintainers
F-spot maintainers
gnome[unmaintained]
Depends on:
Blocks:
 
 
Reported: 2008-10-05 17:16 UTC by Pascal de Bruijn
Modified: 2018-07-01 09:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Always run JpegFilter before ResizeFilter (3.78 KB, patch)
2008-10-10 17:10 UTC, Pascal de Bruijn
needs-work Details | Review
Always run JpegFilter before ResizeFilter (2.31 KB, patch)
2008-11-02 14:19 UTC, Pascal de Bruijn
needs-work Details | Review

Description Pascal de Bruijn 2008-10-05 17:16:42 UTC
Please describe the problem:
F-Spot fails when trying to export (8bit) TIFF files to Flickr, or a local Folder.

Steps to reproduce:
1. Import a TIFF file
2. File -> Export to -> Flickr



Actual results:
[Debug 19:14:56.053] open uri = file:///home/pmjdebruijn/Photos/2008/10/05/IMG_3562_X.tif
System.Exception: Error while uploading ---> System.NotImplementedException: Writing to this file format is not supported
  at FSpot.ImageFile.Save (Gdk.Pixbuf pixbuf, System.IO.Stream stream) [0x00000] 
  at FSpot.Filters.ResizeFilter.Convert (FSpot.Filters.FilterRequest req) [0x00000] 
  at FSpot.Filters.FilterSet.Convert (FSpot.Filters.FilterRequest req) [0x00000] 
  at FlickrRemote.Upload (IBrowsableItem photo, IFilter filter, Boolean is_public, Boolean is_family, Boolean is_friend) [0x00000] --- End of inner exception stack trace ---

  at FlickrRemote.Upload (IBrowsableItem photo, IFilter filter, Boolean is_public, Boolean is_family, Boolean is_friend) [0x00000] 
  at FSpotFlickrExport.FlickrExport.Upload () [0x00000] 


Expected results:
So I'd expect my TIFF (with EXIF), to be potentially resized, and saved as a JPEG+EXIF to be uploaded to Flickr.

Does this happen every time?
Yes.

Other information:
Comment 1 Pascal de Bruijn 2008-10-10 17:10:20 UTC
Created attachment 120348 [details] [review]
Always run JpegFilter before ResizeFilter

ResizeFilter can't handle anything else then JPEGs, therefore we always run JpegFilter before ResizeFilter to be safe.

(I'm currently testing this patch). I'll bump this bug when I've finished testing.
Comment 2 Pascal de Bruijn 2008-11-02 14:19:47 UTC
Created attachment 121815 [details] [review]
Always run JpegFilter before ResizeFilter

New version of the patch
Comment 3 Pascal de Bruijn 2008-11-02 14:25:56 UTC
There are two remaining issues...

1. ExportToFolder still names files bla.tif even when they are converted to JPEG.
2. EXIF information is lost (even though the original TIFFs did have EXIF).
Comment 4 Maxxer 2010-06-19 13:50:13 UTC
Review of attachment 121815 [details] [review]:

patch covers only three exporters, while there are others.

export will be subject of a big rewrite in the (hopefully) close future. up to you if you want to update the patch ;)
Comment 5 Ruben Vermeersch 2010-06-24 14:48:02 UTC
Comment on attachment 120348 [details] [review]
Always run JpegFilter before ResizeFilter

Maintenance update: In the past we've been less than stellar in reviewing patches. As such we have a pile of patches in bugzilla which are outdated and don't apply anymore. Am currently marking all of these as "needs-work". My apologies for this.

Since I've become a maintainer of the project, I've set the personal rule of quickly reviewing all patches, to avoid that this happens again. If you (or anyone) wants to go through the trouble of updating this patch, please talk to us to figure out if it fits in the F-Spot long term roadmap.

Should you, in the future, notice a patch lingering around for too long, please notify us immediately and we'll look into it, to avoid situations like these from happening again.

You can filter these mails by searching for ###F-OLDPATCHCLEANUP###
Comment 6 André Klapper 2018-07-01 09:00:17 UTC
f-spot is not under active development anymore, has not seen code changes for five years, and saw its last tarball release in the year 2010.
Its codebase has been archived: https://gitlab.gnome.org/Archive/f-spot/commits/master

Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is deprecated) if anyone takes the responsibility for active development again.