GNOME Bugzilla – Bug 554111
Orca doesn't speak the Rhythmbox rating widget
Last modified: 2008-11-16 19:03:08 UTC
Steps to reproduce: 1. Get the latest patch by Jonathan Matthew on bug #368641 (thanks Jonathan!!!) 2. Get into the properties dialog (details page) for a song, or go to the Music menu->Playlist->New Automatic Playlist 3. Tab to the rating widget and use Left/Right Arrow to change the rating. Expected results: Orca would speak and braille the rating. Actual results: Orca displays the rating, but doesn't speak it.
Created attachment 119492 [details] [review] revision 1 The rating widget is of ROLE_UNKNOWN and already focused when changing the rating. As a result, speechgenerator.py only speaks the object availability (should the widget be unavailable, which it's not, so we speak nothing). This patch adds a _getDefaultSpeech method to the rhythmbox speech generator to handle this condition. Seems to work. Note that we still don't speak/display anything when the rating widget first gets focus in the new playlist dialog. In that dialog the widget starts out nameless (in contrast, in the Properties dialog, it starts out with a name of 'No Stars').
Created attachment 119493 [details] [review] revision 2 (slight tweak) Forgot to pass along role to the default generator. D'oh!
Created attachment 119500 [details] [review] revision 3: trunk compatible revision I can tell it's going to be one of those evenings.... The svn headers in the speech_generator.py for the rhythmbox script were causing the patch to fail -- including (or rather excluding) a needed import line. So I just updated speech_generator.py. This patch should now apply without failure.
When I first saw this patch, I missed that it was isolated to the existing Rhythmbox script. Now that I see that, this seems like a nice fine patch. (Thanks!)
Thanks Will. Because Jonathan has indicated that he anticipates committing his patch (bug #368641), I've committed ours. Many thanks Jonathan!! Changing to "Blocked" until the Rhythmbox patch is in because currently Orca still doesn't speak the rating widget, but there's nothing more we can do.
Jonathan committed his patch. Closing our bug as FIXED.