After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 553990 - last.fm should prompt for user/pass if unable to login
last.fm should prompt for user/pass if unable to login
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 441293 498577 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-09-26 19:20 UTC by William Jon McCann
Modified: 2008-11-15 09:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (90.95 KB, image/png)
2008-09-26 19:28 UTC, William Jon McCann 		  Details
patch (59.09 KB, patch)
2008-09-30 21:45 UTC, William Jon McCann 		none Details | Review
minor update (59.68 KB, patch)
2008-09-30 21:56 UTC, William Jon McCann 		none Details | Review
update - make dialog not resizeable (59.76 KB, patch)
2008-09-30 22:10 UTC, William Jon McCann 		none Details | Review
updated (65.54 KB, patch)
2008-09-30 23:05 UTC, William Jon McCann 		none Details | Review

Description William Jon McCann 2008-09-26 19:20:02 UTC 
Currently if the lastfm plugin is not able to login it displays the following in the status area:
"Could not log in to Last.fm.  Check your username and password."

First, we may not even be showing the statusbar since it can be turned off in the menus.

Second, it would be better to offer the user the opportunity to login directly.

We probably want to implement this as a per source action.  Maybe something like a yellow bar across the bottom of the source's content area that offers something like:

Username: [         ]  Password: [           ]
Comment 1 William Jon McCann 2008-09-26 19:27:54 UTC 
Actually, now that I look, the way Banshee does it is pretty nice.
Comment 2 William Jon McCann 2008-09-26 19:28:49 UTC 
Created attachment 119443 [details]
screenshot
Comment 3 William Jon McCann 2008-09-30 21:45:58 UTC 
Created attachment 119686 [details] [review]
patch

* Adds a message widget
* Cleans up the preferences dialog a bit
* Calls the preferences dialog from the message widget

I used a widget from gedit that is GPL.  I guess we'll need to relicense it with the exception.

For some reason the primary text in the message area is wrapping too early.  Haven't looked into that yet.
Comment 4 William Jon McCann 2008-09-30 21:56:12 UTC 
Created attachment 119687 [details] [review]
minor update
Comment 5 William Jon McCann 2008-09-30 22:10:38 UTC 
Created attachment 119688 [details] [review]
update - make dialog not resizeable
Comment 6 William Jon McCann 2008-09-30 23:05:17 UTC 
Created attachment 119693 [details] [review]
updated

* Don't changed username/password on each keypress (WTF)
* Queue a relogin attempt when username/password is changed
* Remove the warning message when login succeeds
Comment 7 William Jon McCann 2008-10-01 17:25:42 UTC 
Got permission to relicense.  Committed after review from Bastien.
Comment 8 Jonathan Matthew 2008-11-07 11:55:43 UTC 
*** Bug 498577 has been marked as a duplicate of this bug. ***
Comment 9 Jonathan Matthew 2008-11-15 09:41:48 UTC 
*** Bug 441293 has been marked as a duplicate of this bug. ***