Nope, I was wrong, the last.fm station keeps working it's way through the list.

So wait, what's the problem here? If you have anything in the Play Queue, that will always have top priority for playing first.

Can you provide some specific steps to demonstrate the bug?

Hmm, I was a bit worried that this was intended.  Here's what I was hoping:

I was hoping that the Play Queue would be like the iTunes party shuffle or an On The Go playlist on the iPod.  You can throw a bunch of music onto it as a sort of temporary playlist, but it only starts playing if you tell it to start playing.  The way you describe the play queue (and apparently the way rhythmbox works) seems to make a lot of sense though, and I could really get into a feature like that (and we don't need for Banshee to be an iTunes clone anyway).

There is still an inconsistency, though.  Here's the scenario:
With no music playing, I add a song to my Play Queeu
I choose to start playing music (Song 1) in my Music Library
When Song 1 finishes, Banshee continues onto the following song (Song 2) in the Music Library.
When Song 2 finishes, Banshee starts to play the Play Queue.

If I understand correctly, Banshee should instead start playing whatever I have queued up when Song 1 finishes.

Other scenarios do work as expected:

I play Song 1 in the Music Library
I add a song to the Play Queue
Song 1 finishes and Banshee begins playing the Play Queue

I add music to the Play Queue
I play Song 1 in the Music Library
I switch the view to Last.FM or Podcasts
Song 1 finishes and Banshee begins playing the Play Queue.

The inconsistency only happens when there is already music in the Play Queue but I instead play Song 1 in the Music Library and focus doesn't leave the Music Library while Song 1 is playing.

Sorry this got a bit long and very well may still be confusing.  Let me know if I can explain anything a bit more clearly.

Martin,

this is really a difficult bug to describe.
I tried to reproduce it given your description but it did not get the same result.

Here's what I did :
1) I added 2 songs (X & Y) in the play queue
2) I started to play a random song A in my music library (note that I play with "shuffle by song") by double clicking on 'music library' in the left panel'. I left the focus on 'music library' all the time.
3) when song A finished, song X started to play
4) when song x finished, song Y started to play

This all 'works as designed' to me but in your findings, in step 3 when song A finished it would continue in the music library with a random song B, instead of X from the play queue.

Am I getting this right ?

If not please provide more detail about the scenario.

I'm also running on banshee 1.3.1.

While writing this comment, I also changed my play mode to 'shuffle off' but I came the same findings.

Strider

Okay, I think I can confirm that doing things your way doesn't seem to have a bug.  I don't know if Shuffle by Song makes any difference, but you started playing the Music Library by double clicking on the library (in the left panel).  I started playing a song in the music library by double clicking on a specific song in the library.  Try that and see if you can reproduce it.  I'll keep messing around to see if I can find anything more specific.

Martin,

by double clicking on the song in the library I could reproduce your bug.

So to repeat, this is the scenario :

1) I added 2 songs (X & Y in that order) in the play queue
2) I started to play a specific song A in my music library (I play with
"shuffle by song") by double clicking on it. I left the focus on 'music library' all the time.
3) when song A finished, song B from the music library started to play (B being a random song since I have "shuffle by song"). The song that should have been picked is X and not B.
4) when song B finished, song x started to play
5) when song x finished, song y started to play (as expected)
6) when song y finished, a random song C from the music library started to play (as expected)

I think the status 'unconfirmed' for this bug can be changed now ...

Thanks for testing guys.

For posterity: this seems to be related to bug 524637, but that was fixed. So this could be a regression or just a different cause of the same symptom.

Bug 524637 seems to say that the problem happens if you add a song to the queue while you're already listening to a song, which isn't the case anymore, though they could certainly still be related.

Just as a thought, if items are in the play queue and the user double clicks on a song in the Music Library, does it make sense for Banshee to jump to the items in the play queue after the music library song finishes?  If there are songs in the queue but the user intentionally plays a song in the music library, they probably want to listen to the library instead of the queue.

*** Bug 559244 has been marked as a duplicate of this bug. ***

Additionally I would expect that the song that was queued and stopped by choosing
another song during it's play will be removed from the queue list.

(In reply to comment #8)
> Just as a thought, if items are in the play queue and the user double clicks on
> a song in the Music Library, does it make sense for Banshee to jump to the
> items in the play queue after the music library song finishes?  If there are
> songs in the queue but the user intentionally plays a song in the music
> library, they probably want to listen to the library instead of the queue.
> 

I like the way it works (should work) now, because mostly I just want to temporarily change the track to another track in the library and then would want to continue with the queue list. You can always clear the queue list and add them to a new playlist to save them for later use if you want.

(In reply to comment #10)

> I like the way it works (should work) now, because mostly I just want to
> temporarily change the track to another track in the library and then would
> want to continue with the queue list. You can always clear the queue list and
> add them to a new playlist to save them for later use if you want.
> 

Agreed.  Originally I wanted Banshee's play queue to be more like iTunes' Party Shuffle, but after using Banshee's play queue for awhile, I have to say I'm happy with the way it works (should work).

Just a quick note that patch in bug 553399 (among other things) fixes this problem.

(In reply to comment #12)
> Just a quick note that patch in bug 553399 (among other things) fixes this
> problem.

It seems your patch for Auto DJ (Bug 565767) also fixes this bug.

(In reply to comment #13)
> It seems your patch for Auto DJ (Bug 565767) also fixes this bug.

Yep, it supersedes the one from bug 553399.

The fix is committed as part of the patch from bug 565767.