After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 552965 - aria-valuetext ignored
aria-valuetext ignored
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.22.x
Other All
: Normal normal
: 2.24.4
Assigned To: Willie Walker
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2008-09-20 01:43 UTC by Peter Parente
Modified: 2009-01-29 22:11 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
First pass at this (2.73 KB, patch)
2009-01-28 19:12 UTC, Willie Walker
none Details | Review
A little better patch that also includes some regression test changes (16.14 KB, patch)
2009-01-29 22:06 UTC, Willie Walker
committed Details | Review

Description Peter Parente 2008-09-20 01:43:38 UTC
Please describe the problem:
Orca announces the aria-valuenow on a role=slider node as a floating point number (1.0, 2.0, 3.0, etc.) even when the aria-textnow is available with a purposeful human-readable description of the value (good, better, best, etc.).



Steps to reproduce:
See http://mindtrove.info/html/rating-tutorial.html

Actual results:


Expected results:
Orca should report the aria-textnow when available.

Does this happen every time?
Yes.

Other information:
http://groups.google.com/group/free-aria/browse_thread/thread/398cf7197cd4ad3
Comment 1 Willie Walker 2009-01-15 22:31:08 UTC
We'll try to take a look at this as we revisit the ARIA support in Orca.  Thanks!
Comment 2 Willie Walker 2009-01-28 19:12:06 UTC
Created attachment 127415 [details] [review]
First pass at this

Here's a first pass that seems to work rather nicely with the test page given in the opener for the bug report.  It also cleans up some redundancy in the Gecko speech generator.  Running the regression tests now.
Comment 3 Willie Walker 2009-01-29 22:06:05 UTC
Created attachment 127498 [details] [review]
A little better patch that also includes some regression test changes

This patch changes how we grab the valuetext value -- it just looks at the remainder of the property value instead of splitting the string at ":".  It occurred to me that the valuetext value might have :'s in it.  D'Oh.

In running the regression tests, I also found that the mozilla and dojo tests both use valuetext, so the tests needed adjusting as well.  A couple of the dojo slider examples need some improvement in their valuetext support, IMO, so I also logged a bug here: http://bugs.dojotoolkit.org/ticket/8539.  The only reason I'm anal about that is that they should promote accessible design since a lot of people code by example.

It pylints and regression tests well.  Committed to trunk.
Comment 4 Willie Walker 2009-01-29 22:11:43 UTC
Also committed to gnome-2-24 for Orca v2.24.4.