After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 552288 - Patch adding the possiblity to "wrap around" the edges when switching tabs
Patch adding the possiblity to "wrap around" the edges when switching tabs
Status: RESOLVED DUPLICATE of bug 92139
Product: gnome-terminal
Classification: Core
Component: general
2.22.x
Other All
: Normal minor
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-09-14 22:41 UTC by Kevin Read
Modified: 2008-09-15 11:26 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
Patch that adds a new (optional) tab-switching behaviour (3.89 KB, patch)
2008-09-14 22:42 UTC, Kevin Read
needs-work Details | Review

Description Kevin Read 2008-09-14 22:41:09 UTC
In a terminal window with multiple tabs, gnome-terminal won't wrap around when switching tabs. What I mean with this is that when the first tab is active and I change to the previous tab, it won't select the last tab - instead it will do nothing. While there is nothing wrong with this behaviour in itself, it is quite annoying when you have more than two or three tabs open and you want to go from left to right quickly. This wrap-around is default behaviour in some terminal emulators, for instance with XFCE Terminal.

This patch adds a global GConf key named "tab_switching_wraparound", which is then accessed each time a tab switch signal is received, and also when the sensitivity of the tab switching menu items is set.

Other information:
As this is my first gnome-related patch, I'd be glad for any help concerning coding style and/or patch format in general.
Comment 1 Kevin Read 2008-09-14 22:42:20 UTC
Created attachment 118712 [details] [review]
Patch that adds a new (optional) tab-switching behaviour
Comment 2 Kevin Read 2008-09-14 22:43:42 UTC
Ah yes, the patch is against gnome-terminal-2.22.3, but as it is quite minimal it should apply against newer versions (I hope).
Comment 3 Christian Persch 2008-09-15 11:24:48 UTC
(In reply to comment #2)
> Ah yes, the patch is against gnome-terminal-2.22.3, but as it is quite minimal
> it should apply against newer versions (I hope).

Actually it doesn't apply; gnome-terminal 2.23.x was extensively reworked.
Comment 4 Christian Persch 2008-09-15 11:26:02 UTC

*** This bug has been marked as a duplicate of 92139 ***