After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 552122 - Add PLD groups and services
Add PLD groups and services
Status: RESOLVED FIXED
Product: gnome-system-tools
Classification: Deprecated
Component: general
2.22.x
Other Linux
: Normal normal
: ---
Assigned To: Milan Bouchet-Valat
Carlos Garnacho
Depends on:
Blocks:
 
 
Reported: 2008-09-13 13:35 UTC by Patryk Zawadzki
Modified: 2009-08-16 17:35 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
The current patch we use for groups (1008 bytes, patch)
2008-09-13 13:36 UTC, Patryk Zawadzki
committed Details | Review
The current patch we use for services (5.59 KB, patch)
2008-09-13 13:37 UTC, Patryk Zawadzki
reviewed Details | Review

Description Patryk Zawadzki 2008-09-13 13:35:58 UTC
Attached are current patches.

This bug is part of pushing PLD patches upstream.
Comment 1 Patryk Zawadzki 2008-09-13 13:36:42 UTC
Created attachment 118659 [details] [review]
The current patch we use for groups
Comment 2 Patryk Zawadzki 2008-09-13 13:37:05 UTC
Created attachment 118660 [details] [review]
The current patch we use for services
Comment 3 André Klapper 2008-11-21 22:42:28 UTC
*ping*
Comment 4 André Klapper 2009-01-29 01:06:24 UTC
Carlos: ping
Comment 5 André Klapper 2009-02-24 19:16:56 UTC
Ah.
g-s-t is unmaintained:
http://blogs.gnome.org/carlosg/2008/02/01/two-new-children-in-cookieville/
Comment 6 Milan Bouchet-Valat 2009-07-26 10:08:20 UTC
Sorry for the delay, but could you elaborate a little more about that patch? I perfectly see how this could be useful, but are other distributions supposed to follow those group policies too? e.g. in Ubuntu the usb and cdwrite groups don't exist. Same for services. If we add these, we need to make all downstream know that they should use it - else we add options that will mislead users. Thanks!
Comment 7 Patryk Zawadzki 2009-07-26 18:47:21 UTC
I thought the point of having that list was being able to detect interesting groups among those present in the system, not creating all of them on each and every distro.
Comment 8 Milan Bouchet-Valat 2009-07-28 15:03:41 UTC
Good point! I'm not very familiar yet with all the internals of the g-s-t. If it works just like boot services are detected, so we can and should upstream that patch. BTW, if you have other patches that should go the same way, please file bugs!

I've prepared a commit with your patch updated, but I'd like a precision about alphabetical order: why is NetworkManager at the top, and not with the 'n'? should really alsasound go after alsa-utils (I don't know how the - is sorted)? Since you tested it, I guess you know better than I do.

Thanks!
Comment 9 Milan Bouchet-Valat 2009-08-16 09:15:49 UTC
Ping?
Comment 10 Patryk Zawadzki 2009-08-16 13:11:16 UTC
About ordering:

Not sure about the order, I'm used to ASCII ordering in source code. In the GUI we should let GTK+ order items by translation anyway.
Comment 11 Milan Bouchet-Valat 2009-08-16 17:35:50 UTC
OK, I've reordered them using the 'sort' command, that should be more correct. Pushed as 6743464cb8e1aed196afe5b07d876bfe50990eb7. Thanks again!