Bug 549986 – crash in Help: I've tried to open items...

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 549986 - crash in Help: I've tried to open items...


Summary:	crash in Help: I've tried to open items...


Status:	RESOLVED FIXED

Product:	yelp
Classification:	Applications
Component:	General
Version:	2.22.x
Hardware:	Other All

Importance:	High critical
Target Milestone:	---
Assigned To:	Yelp maintainers
QA Contact:	Yelp maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2008-08-30 20:25 UTC by v.merlin
Modified:	2008-09-01 20:01 UTC

See Also:
GNOME target:	---
GNOME version:	2.21/2.22

Attachments
Fix incorrect pointer check (724 bytes, patch) 2008-08-31 08:35 UTC, Josselin Mouette	committed	Details \| Review
Accept text/plain documents (3.64 KB, patch) 2008-08-31 09:16 UTC, Josselin Mouette	rejected	Details \| Review

Description v.merlin 2008-08-30 20:25:12 UTC

Version: 2.22.1

What were you doing when the application crashed?
I've tried to open items with txt extension in Debian Lenny help.  This bug was also reported in Debian reportbug number 497086


Distribution: Debian lenny/sid
Gnome Release: 2.22.3 2008-06-30 (Debian)
BugBuddy Version: 2.22.0

System: Linux 2.6.26-1-amd64 #1 SMP Wed Aug 20 12:09:32 UTC 2008 x86_64
X Vendor: The X.Org Foundation
X Vendor Release: 10402000
Selinux: No
Accessibility: Enabled
GTK+ Theme: Mist
Icon Theme: Mist

Memory status: size: 499089408 vsize: 499089408 resident: 65245184 share: 27041792 rss: 65245184 rss_rlim: 18446744073709551615
CPU usage: start_time: 1220126990 rtime: 1990 utime: 1246 stime: 744 cutime:25 cstime: 27 timeout: 0 it_real_value: 0 frequency: 100

Backtrace was generated from '/usr/bin/yelp'

[Thread debugging using libthread_db enabled]
[New Thread 0x7faf95f07780 (LWP 22577)]
[New Thread 0x432e5950 (LWP 29711)]
[New Thread 0x42ae4950 (LWP 22581)]
[New Thread 0x422e3950 (LWP 22580)]
[New Thread 0x41ae2950 (LWP 22579)]
[New Thread 0x40d24950 (LWP 22578)]
0x00007faf928bd5ff in waitpid () from /lib/libpthread.so.0

+ Trace 205900

Thread 1 (Thread 0x7faf95f07780 (LWP 22577))

#0 waitpid
from /lib/libpthread.so.0
#1 g_spawn_sync
from /usr/lib/libglib-2.0.so.0
#2 g_spawn_command_line_sync
from /usr/lib/libglib-2.0.so.0
#3 ??
from /usr/lib/gtk-2.0/modules/libgnomebreakpad.so
#4 <signal handler called>
#5 strlen
from /lib/libc.so.6
#6 g_str_has_suffix
from /usr/lib/libglib-2.0.so.0
#7 resolve_is_man_path
at yelp-utils.c line 140
#8 resolve_full_file
at yelp-utils.c line 192
#9 yelp_uri_resolve
at yelp-utils.c line 380
#10 yelp_window_load
at yelp-window.c line 1005
#11 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#12 ??
from /usr/lib/libgobject-2.0.so.0
#13 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#14 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#15 html_open_uri
at yelp-html.cpp line 101
#16 ??
from /usr/lib/xulrunner-1.9/libxul.so
#17 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#18 ??
from /usr/lib/libgobject-2.0.so.0
#19 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#20 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#21 ??
from /usr/lib/xulrunner-1.9/libxul.so
#22 ??
from /usr/lib/xulrunner-1.9/libxul.so
#23 ??
from /usr/lib/xulrunner-1.9/libxul.so
#24 ??
from /usr/lib/xulrunner-1.9/libxul.so
#25 ??
from /usr/lib/xulrunner-1.9/libxul.so
#26 ??
from /usr/lib/xulrunner-1.9/libxul.so
#27 ??
from /usr/lib/xulrunner-1.9/libxul.so
#28 ??
from /usr/lib/xulrunner-1.9/libxul.so
#29 ??
from /usr/lib/xulrunner-1.9/libxul.so
#30 ??
from /usr/lib/xulrunner-1.9/libxul.so
#31 ??
from /usr/lib/xulrunner-1.9/libxul.so
#32 ??
from /usr/lib/xulrunner-1.9/libxul.so
#33 ??
from /usr/lib/xulrunner-1.9/libxul.so
#34 g_main_context_dispatch
from /usr/lib/libglib-2.0.so.0
#35 ??
from /usr/lib/libglib-2.0.so.0
#36 g_main_loop_run
from /usr/lib/libglib-2.0.so.0
#37 gtk_main
from /usr/lib/libgtk-x11-2.0.so.0
#38 main
at yelp-main.c line 121
#0 waitpid
from /lib/libpthread.so.0



----------- .xsession-errors (6 sec old) ---------------------
** (yelp:22577): WARNING **: Exception in gr::RangeSegment
** (yelp:22577): WARNING **: Exception in gr::RangeSegment
** (yelp:22577): WARNING **: Exception in gr::RangeSegment
** (yelp:22577): WARNING **: Exception in gr::RangeSegment
** (yelp:22577): WARNING **: Exception in gr::RangeSegment
** (yelp:22577): WARNING **: Exception in gr::RangeSegment
(yelp:22577): GLib-CRITICAL **: g_str_has_suffix: assertion `suffix != NULL' failed
(yelp:22577): GLib-CRITICAL **: g_str_has_suffix: assertion `suffix != NULL' failed
--------------------------------------------------

Comment 1 Josselin Mouette 2008-08-31 08:35:10 UTC

Created attachment 117680 [details] [review]
Fix incorrect pointer check

This patch fixes the crash (a wrong pointer check) but the text files will still refuse to open.

Comment 2 Josselin Mouette 2008-08-31 09:16:26 UTC

Created attachment 117682 [details] [review]
Accept text/plain documents

And these are the changes needed to make text/plain documents accessible.

Comment 3 Don Scorgie 2008-09-01 18:13:21 UTC

Thanks for the bug report and thanks the patch.  I've committed the first patch to SVN.  I don't think it's yelp's job to open text files - we have a perfectly good text editor ;)  I've instead made text documents default to opening in the users preferred application.

Marking as Fixed.

2008-09-01  Don Scorgie  <dscorgie@svn.gnome.org>

        * src/yelp-utils.c (resolve_is_man_path):
        Don't crash when trying to load text files
        bug #549986 - Josselin Mouette

Comment 4 Josselin Mouette 2008-09-01 20:01:14 UTC

(In reply to comment #3)
> Thanks for the bug report and thanks the patch.  I've committed the first patch
> to SVN.  I don't think it's yelp's job to open text files - we have a perfectly
> good text editor ;)

Well, we have a good web browser, yet yelp opens HTML documents. If they are registered in scrollkeeper, it means they are relevant for yelp, whether they are HTML, XML or text.