GNOME Bugzilla – Bug 549700
Drop libglade dependency and use GtkBuilder instead
Last modified: 2008-08-28 16:58:17 UTC
SSIA, patch coming.
Created attachment 117517 [details] [review] [PATCH] Drop glade dependency and use GtkBuilder instead. configure.ac | 3 +- gnome-screenshot/Makefile.am | 10 +- gnome-screenshot/gnome-screenshot.c | 2 - gnome-screenshot/gnome-screenshot.glade | 259 ------------------------------- gnome-screenshot/gnome-screenshot.ui | 241 ++++++++++++++++++++++++++++ gnome-screenshot/screenshot-dialog.c | 27 ++-- gnome-screenshot/screenshot-dialog.h | 1 - 7 files changed, 262 insertions(+), 281 deletions(-)
awesome. patch looks good, but the po/POTFILES.in should also be changed to allow the i18n teams to fix up their translations. I don't think this warrants a string freeze break, but I'll ask.
Created attachment 117518 [details] [review] [PATCH] Leftover: also edit POTFILES.in po/POTFILES.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Ok, let's wait for i18n then :)
for reference, from IRC: 13:52 < uws> ebassi: i think the gtkbuilder move is safe 13:52 < uws> ebassi: you can try "intltool-update it" in the po/ directory, note the numbers 13:52 < uws> ebassi: then apply the patch, run "intltool-update it" in the po/ directory again, and check the numbers also, the POTFILES.in should be: [type: gettext/glade]gnome-screenshot/gnome-screenshot.ui because intltool does not natively support gtkbuilder files.
Created attachment 117523 [details] [review] [PATCH] Fix POTFILES.in with the correct mime type this time. po/POTFILES.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
with the patch: anarki@pluto:~/Sources/gnome-utils/po$ intltool-update it ...................................................................................... done. 700 translated messages, 27 fuzzy translations, 11 untranslated messages. without the patch: anarki@pluto:~/Sources/gnome-utils/po$ intltool-update it ...................................................................................... done. 701 translated messages, 26 fuzzy translations, 11 untranslated messages. I saw that new strings are automatically picked up from the .ui file by doing intltool-update. I don't really know how all this stuff works though.
a fuzzy string less. might be a fluke, but at least there aren't new untranslated strings. I'd say: go ahead and commit - we'll deal with the l10n teams in case shit happens.
Committed to trunk, closing as FIXED. 2008-08-28 Cosimo Cecchi <cosimoc@gnome.org> * Makefile.am: * gnome-screenshot.c: (main): * gnome-screenshot.glade: * gnome-screenshot.ui: * screenshot-dialog.c: (screenshot_dialog_new), (screenshot_dialog_enable_dnd), (screenshot_dialog_get_toplevel): * screenshot-dialog.h: Drop libglade dependency. Use GtkBuilder instead (#549700).