After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 549558 - "Download Messages for Offline Usage" still sensitive in offline mode
"Download Messages for Offline Usage" still sensitive in offline mode
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.30.x (obsolete)
Other All
: Normal minor
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
evolution[kill-bonobo]
Depends on:
Blocks:
 
 
Reported: 2008-08-27 10:35 UTC by Paul Bolle
Modified: 2013-09-13 01:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.65 KB, patch)
2010-01-21 17:08 UTC, Viswanath S 		committed Details | Review

Description Paul Bolle 2008-08-27 10:35:27 UTC 
The "Download Messages for Offline Usage" menu item is still sensitive in offline mode.

This makes little sense to me. I'd expect to be not able to download any messages in offline mode.

(I haven't actually been able to determine whether this menu item really does anything when in offline mode. There's no feedback that I noticed. Neither have I checked the code yet.)

Other information:
If my understanding of this menu item is correct, I'm happy to give a patch to set/unset the sensitivity of this item a try.

(If I'm incorrect, the menu item needs to renamed.)
Comment 1 Paul Bolle 2008-08-27 10:39:30 UTC 
Note that this item's tip looks incomplete:
    "Download messages of accounts/folders marked for offline"

Should "usage" be appended?
Comment 2 Matthew Barnes 2008-08-27 14:36:47 UTC 
Confirming.  Still present in 2.23.

May want to hold off on this until BonoboUI is removed from Evolution (in progress, targetted for 2.25).  A GtkAction-based solution will be simpler.
Comment 3 Viswanath S 2010-01-21 17:08:20 UTC 
Created attachment 151953 [details] [review]
Proposed patch
Comment 4 Matthew Barnes 2010-01-21 17:23:54 UTC 
Patch looks perfect, thanks much!

Committed in:
http://git.gnome.org/browse/evolution/commit/?id=5787b629312f2c2132a666a9ee4d8b2091815ad1

I'll take care of announcing the string change.