After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 548843 - Need translator comments for several strings
Need translator comments for several strings
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: gphoto backend
git master
Other All
: Normal major
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2008-08-21 11:11 UTC by Wouter Bolsterlee (uws)
Modified: 2008-09-17 21:10 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
gvfs-gphoto-strings.patch (4.08 KB, patch)
2008-08-21 17:06 UTC, Hans Petter Jansson
committed Details | Review

Description Wouter Bolsterlee (uws) 2008-08-21 11:11:13 UTC
The strings below need translator comments since they're hard (or even impossible) to translate right now. E.g. what does "port info list" mean at all?


#: ../daemon/gvfsbackendgphoto2.c:1325
msgid "Error listing folders to figure out ignore prefix"

#: ../daemon/gvfsbackendgphoto2.c:1482
msgid "Error creating port info list"

#: ../daemon/gvfsbackendgphoto2.c:1492
msgid "Error loading info list"

#: ../daemon/gvfsbackendgphoto2.c:1504
msgid "Error looking up port info from port info list"

#: ../daemon/gvfsbackendgphoto2.c:1514
msgid "Error getting port info from port info list"

#: ../daemon/gvfsbackendgphoto2.c:1527
msgid "Error setting port info"


Marking major since it affects many translators.
Comment 1 David Zeuthen (not reading bugmail) 2008-08-21 16:51:36 UTC
Actually, I'm not sure these errors should be translated at all... most of them indicate either inherent bug in the libgphoto2 driver or broken hardware.

Is it normal to translate such low level errors? If so, I guess I can add some Translator: comments...
Comment 2 Hans Petter Jansson 2008-08-21 17:06:34 UTC
Created attachment 117146 [details] [review]
gvfs-gphoto-strings.patch

I committed the attached diff just now. It changes the strings in question to be more humane.
Comment 3 David Zeuthen (not reading bugmail) 2008-08-21 17:19:41 UTC
Looks good to me. Thanks Hans Petter!
Comment 4 Wouter Bolsterlee (uws) 2008-08-22 07:40:02 UTC
Hey, what about merging these similar strings into one single string (use three times) that covers all cases?

+      error = get_error_from_gphoto2 (_("Error loading device information"), rc);
+      error = get_error_from_gphoto2 (_("Error looking up device information"), rc);
+      error = get_error_from_gphoto2 (_("Error getting device information"), rc);
Comment 5 Wouter Bolsterlee (uws) 2008-08-22 07:41:00 UTC
Oh, and if you just reuse one of the string no further announcement to the gnome-i18n  list is needed. 
Comment 6 Hans Petter Jansson 2008-08-22 18:53:07 UTC
Well, I think the gphoto backend author intended to be able to distinguish the messages for debugging purposes...
Comment 7 Hendrik Richter 2008-08-28 06:13:39 UTC
#: ../daemon/gvfsbackendgphoto2.c:3189
msgid "Not supported (src is dir, dst is dir)"

#: ../daemon/gvfsbackendgphoto2.c:3197
msgid "Not supported (src is dir, dst is existing file)"

#: ../daemon/gvfsbackendgphoto2.c:3209
msgid "Not supported (src is file, dst is dir)"

Why are cryptic strings like "src" and "dst" used instead of "source" and "destination"? Should translators translate them (I did)?
Comment 8 Wouter Bolsterlee (uws) 2008-09-17 21:10:10 UTC
Hendrik, I think the messages are for debugging use only. Feel free to translate them, or leave them as is. Regular users will never see this string. Marking this report fixed, since the issues raised have been resolved.