After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 548836 - Build failure
Build failure
Status: RESOLVED FIXED
Product: tomboy
Classification: Applications
Component: General
0.11.x
Other Linux
: Normal blocker
: ---
Assigned To: Tomboy Maintainers
Tomboy Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-08-21 10:45 UTC by Vincent Untz
Modified: 2008-08-21 17:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove bundled panelapplet code (27.96 KB, patch)
2008-08-21 13:05 UTC, Sandy Armstrong
needs-work Details | Review
Updated patch, should support 2.23.90 (29.02 KB, patch)
2008-08-21 14:32 UTC, Sandy Armstrong
committed Details | Review
path from Mandriva (1.31 KB, patch)
2008-08-21 16:19 UTC, Götz Waschk
none Details | Review

Description Vincent Untz 2008-08-21 10:45:35 UTC
panelapplet/ChangeBackgroundHandler.cs(11,30): error CS0234: The type or namespace name `PanelAppletBackgroundType' does not exist in the namespace `Gnome'. Are you missing an assembly reference?

It looks like changing Gnome to _Gnome fixes this.

Also, it seems that gnome-desktop-sharp has bindings for the panel applet library  now. Maybe tomboy should switch to it?
Comment 1 Sandy Armstrong 2008-08-21 12:41:34 UTC
What distro/version is this?  And what versions of gnome-sharp2 and gnome-desktop-sharp2 do you have installed?

I'll look into dumping panelapplet.
Comment 2 Sandy Armstrong 2008-08-21 13:05:39 UTC
Created attachment 117135 [details] [review]
Remove bundled panelapplet code

Here's the comment made two years ago as justification for having our own panelapplet code.  Apparently there was an issue with using transparent backgrounds.

// Work around bug in Gtk# panel applet bindings by using a local copy with
// fixed OnBackgroundChanged marshalling.

Well, I've tested this patch with gnome*-sharp 2.20.1, and I do not see any problems.  Vincent, I suspect you are using a newer version and something has changed names or moved, which is why you are experiencing build errors.  I suspect if you try my patch you will still be unable to build.

Things left to do in this patch:
* Find out what minimum version of gnome*-sharp2 is needed
* Handle your problem, which is either a name change or a member move, most likely
Comment 3 Vincent Untz 2008-08-21 13:09:41 UTC
Sandy: this is in jhbuild, with gnome-desktop-sharp 2.23.90 and gnome-sharp 2.23.90.

Note that this is one bug blocking the 2.23.90 release, so having a new tarball out asap would really be great.
Comment 4 Sandy Armstrong 2008-08-21 13:25:31 UTC
From gnome-sharp ChangeLog:

	* *: Update to Gnome 2.23.5 release API.  Remove print and panel
	APIs from gnome-sharp.dll into their own assemblies now located in
	gnome-desktop-sharp.

From gnome-desktop-sharp ChangeLog:

	* *: Update to GNOME 2.23.5 API.  Add gnome-print-sharp.dll
	and gnome-panel-sharp.dll assemblies, along with .pcs to detect
	their availability.

And, also very important from gnome-desktop-sharp ChangeLog:

	* configure.in: update gtk-sharp requirement to 2.12.1 since the
	gnomepanel glue generation doesn't occur using 2.12.0.  This breaks
	the build since it's expecting a generated.c to be present.
	[Fixes #418291]


So anyway, it looks like a few small fixes to Tomboy's configure.in will make all of this happy-happy-joy-joy again.  I'll have this fixed today (with a release).  Sorry Vincent, I should have been tracking this bindings split more closely.  :-/
Comment 5 Vincent Untz 2008-08-21 13:42:00 UTC
Don't worry -- there were other issues anyway. Thanks for being reactive!
Comment 6 Sandy Armstrong 2008-08-21 14:32:51 UTC
Created attachment 117142 [details] [review]
Updated patch, should support 2.23.90

This one will hopefully work correctly with 2.23.90, but unfortunately I cannot currently test it.  Does it work for you?
Comment 7 Götz Waschk 2008-08-21 16:19:30 UTC
Created attachment 117145 [details] [review]
path from Mandriva

This is my patch that makes tomboy 0.11.2 build with gnome-sharp 2.23.90 and gnome-desktop-sharp 2.23.90 and gtk-sharp 2.12.2.
Comment 8 Sandy Armstrong 2008-08-21 17:18:52 UTC
Good, that patch looks just like mine.  :-)  Gotz, does Tomboy then run correctly for you as a panel applet?  Having trouble with vuntz's environment.
Comment 9 Sandy Armstrong 2008-08-21 17:39:54 UTC
Committed my fix with a few improvements in r2090.  Gotz, if you have time to test that would be awesome.  I'm going to try to set up an environment real quick to test it properly.

I will be releasing Tomboy 0.11.3, which only features this fix, in about an hour.