After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 548772 - Navigation System->Administration->Authorizations tree results in bad or no speech
Navigation System->Administration->Authorizations tree results in bad or no s...
Status: RESOLVED OBSOLETE
Product: policykit-gnome
Classification: Platform
Component: authorizations tool
unspecified
Other All
: Normal normal
: ---
Assigned To: Willie Walker
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-08-21 00:32 UTC by Willie Walker
Modified: 2009-06-22 16:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Test case (290 bytes, text/plain)
2009-02-09 22:29 UTC, Willie Walker
  Details
Work in progress (6.11 KB, patch)
2009-02-10 15:50 UTC, Willie Walker
needs-work Details | Review

Description Willie Walker 2008-08-21 00:32:16 UTC
From http://mail.gnome.org/archives/orca-list/2008-August/msg00006.html:

"I have ubuntu 8.04 and the latest orca from svn.
It seems orca doesn't read some items of some tree views, for example, the 
one on authorizations program (system menu ->  administration -> 
authorizations), or the gnome-device-manager. Even if I press insert+f5, 
sometimes orca doesn't read the item and I have to perform some tries."

In reproducing this problem, I noticed that the appearance/disappearance of stuff in the right hand side of the authorizations page as you arrow up/down the tree results in the bad behavior.  I also notice no speech or just the presentation of "page grayed".  If I tab away from the tree and back to it, however, speech comes back until I cause the disappearance/appearance of stuff in the right hand side of the page.
In reproducing this problem, I also noticed
Comment 1 Willie Walker 2008-08-21 00:33:00 UTC
Ignore this last chunk of text in the opening comment: "In reproducing this problem, I also noticed"

Comment 2 Willie Walker 2009-01-21 16:06:08 UTC
This might be a candidate for 2.26.0.
Comment 3 Willie Walker 2009-02-09 22:29:51 UTC
Created attachment 128340 [details]
Test case

This simple test case shows that the polkit-gnome-authorization app is setting focus to a page tab when the user arrows to a "leaf node" in the tree, but never resetting focus back to the tree.  As a result, Orca does not present new changes to the tree because the tree no longer has focus.

To me, this seems like a bug in polkit-gnome-authorization, and I'd guess it might have to do with the calls to gtk_notebook_get_current_page in http://svn.gnome.org/viewvc/policykit-gnome/trunk/tools/polkit-gnome-authorization.c?view=markup.

I'm not quite sure what to do here.  One might be that the "use page tabs" model in the app is a bit strange and might be better done some other way (e.g., using panels like various setup wizards do).  Another might be to ensure that focus ends up back on the tree if the calls to gtk_notebook_get_current_page are indeed the culprit causing the page tab to get focus.

As an aside, it is strange that when the page tab has focus the up/down keys change the tree table selection.  It'd like two things have focus at once.
Comment 4 Willie Walker 2009-02-09 22:37:08 UTC
As a possible fix, maybe adding gtk_tree_view_set_cursor(treeview) calls right after the calls to gtk_notebook_set_current_page (not 'get' -- sorry for the typo) might do it.
Comment 5 Willie Walker 2009-02-09 22:51:22 UTC
I'm having trouble building policykit-gnome (can't find all the dependencies I need to download).  Adding fcrozat for his thoughts.  Frédéric, what do you think of the possible solution in comment #4?
Comment 6 Willie Walker 2009-02-10 15:50:01 UTC
Created attachment 128384 [details] [review]
Work in progress

This is a patch for the polkit-gnome-authorization file.  It succeeds in making the informational labels focusable/navigable, but fails in the following:

1) Solving the original focus jumping problem.  You'll see these two commented out lines:

 /*gtk_widget_grab_focus (GTK_WIDGET (treeview));*/

When uncommented, they cause these errors to be emitted when you arrow to a leaf node in the tree:

(polkit-gnome-authorization:27925): Gtk-CRITICAL **: gtk_tree_view_set_cursor_
n_cell: assertion `tree_view->priv->tree != NULL' failed

2) Preventing the informational labels from being selected.  There's supposed to be a "gtk-label-select-on-focus" property on the label (http://svn.gnome.org/viewvc/gtk%2B/trunk/gtk/gtklabel.c?r1=14493&r2=14494&), but I end up seeing these warnings:

(polkit-gnome-authorization:27410): GLib-GObject-WARNING **: IA__g_object_set_valist: object class `GtkLabel' has no property named `select-on-focus'

Finally, the "Action", "Implicit Authorizations", and "Explicit Authorizations" areas really should be GtkFrames with labels set for them via gtk_frame_set_label_widget - http://library.gnome.org/devel/gtk/stable/GtkFrame.html#gtk-frame-set-label-widget.  With this, the bolding should automatically happen and the needed hierarchical context will be set up.
Comment 7 Willie Walker 2009-02-10 15:52:40 UTC
Reassigning to policykit-gnome since this all is really an a11y problem in its code.  Us orcanians are still willing to help out where we can, though.  The previous comment gives the status of where we are, and I need some help from some GTK+ usage experts to take things the next step to resolving these a11y issues.
Comment 8 Willie Walker 2009-02-10 15:54:52 UTC
(In reply to comment #6)
> Created an attachment (id=128384) [edit]
> Work in progress

Whoops - ignore the configure.ac changes.  I only used them to create a tools/Makefile I could then modify to build the app.
Comment 9 David Zeuthen (not reading bugmail) 2009-06-22 16:25:58 UTC
This tool is no longer part of polkit-gnome - it will be replaced by a simpler tool very soon but that tool is not written yet. I'll make sure to test that it works with orca/other ATs. Thanks for your work anyway.