After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 548546 - Fullscreen toolbar takes long to display
Fullscreen toolbar takes long to display
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: 2.26
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2008-08-19 22:20 UTC by Michael Monreal
Modified: 2008-10-12 19:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to show the bar at toggling fullscreen (481 bytes, patch)
2008-09-02 12:13 UTC, Felix Kaser
committed Details | Review
shows the bar at fullscreen toggle and sets the utility hint for the popup (3.44 KB, patch)
2008-09-04 15:07 UTC, Felix Kaser
committed Details | Review

Description Michael Monreal 2008-08-19 22:20:15 UTC
Perhaps I have missed a trick but if I go to fullscreen and move the mouse, the toolbar should appear, right? It does, but only after about 15-20 seconds. I have seen it pop up instandly in previous svn revisions though.
Comment 1 daniel g. siegel 2008-08-19 22:28:32 UTC
hmm.. well it should appear if you move the mouse to the bottom of your screen?

tell me if i didnt get you ;)
Comment 2 Michael Monreal 2008-08-20 07:42:41 UTC
Eh... :)
well: there's a black bar right below the actual webcam image when I go fullscreen, which is about 1.2 cm hight. Moving the mouse to half of it (so about 6 mm from the button) does nothing. Then there's a zone which is about 3 mm thin where the toolbar appears. If I quickly move the mouse to the bottom of the screen and move it there (in the remaining 2-3 mm, so the mouse can actually be visible) the toolbar does not appear.

IMHO the zone where the toolbar appears has to be much much larger. There's no rule which says "if you are stuck on fullscreen, move your mouse to a special area on the screen to have a toolbar". For me the totem fullscreen works better, which shows the toolbar regardless of where the mouse is, if you move the mouse: it makes the toolbar much more discoverable. Perhaps this whith a "move the mouse at least 50px" threshold or something?
Comment 3 Filippo Argiolas 2008-08-20 08:29:47 UTC
I think Michael is right, there is some inconsintency across GNOME apps about fullscreen toolbars. 

We activate it moving the mouse on bottom, EoG does it moving the mouse on top, Totem just moving the mouse, Evince toolbar is always visible (well it has the presentation mode too with no toolbar)... did I forgot anyone?

I don't quite like totem approach and I think that moving the mouse on a screen side is not so unintuitive, but I'm not an usability expert, is there something about this in the HIG (too lazy to check :P)

What about forwarding this bug to gnome-desktop?
Comment 4 Michael Monreal 2008-08-20 09:03:02 UTC
Yeah it would be really nice to have a unified look and feel for fullscreen stuff across GNOME. Speaking of which, whouldn't this be a nice use for Clutter(-like) widgets?
Comment 5 Felix Kaser 2008-08-30 17:23:00 UTC
In cheese there is no "sensitivity-field" which is x cm big! The fullscreen bar gets visible when the mouse is on the absolute bottom of the screen! I too don't know whats best but in my opinion this one works fine! It does not work like totem, more like eog but not exactly same!

I suggest closing this bug...its not true that the toolbar takes long to display ^^

idea: show the fullscreen toolbar at the time fullscreen gets toggled! so the user knows where he can find the toolbar?! Thats problematic with the effects notebook site, because there I've set the timeout of the bar to nearly nothing, because it overlays the effect buttons! Showing the fullscreen toolbar when fullscreen in effects mode gets toggled would flash it up for a second...
Comment 6 daniel g. siegel 2008-08-30 17:54:29 UTC
felix: what about showing the toolbar if the user moves the mouse? at the end he wants to do something _if_ the touches the mouse, not?

showing the toolbar when entering in fullscreen mode is a good idea
Comment 7 Felix Kaser 2008-08-31 09:18:25 UTC
daniel: think of the effects mode! there the user moves the mouse without wanting the toolbar to pop up!

Making two different ways how the toolbar gets showed on user input for image preview and effects mode is not a good idea I think....
Comment 8 Felix Kaser 2008-09-02 12:13:21 UTC
Created attachment 117840 [details] [review]
patch to show the bar at toggling fullscreen

This (very small) patch should do it! When toggling to fullscreen the fullscreen bar shows up, so the user knows where he can find the bar!

the problem is, that the timeout in effects mode is very low, so if the user is in effects mode and toggles to fullscreen the bar does not show up!

please review the patch ;) shouldn't take more than one minute and than commit to svn please!
Comment 9 daniel g. siegel 2008-09-02 17:11:32 UTC
seems ok for me!

just a question: why do we have two timeouts? wouldnt just one work too?
Comment 10 Felix Kaser 2008-09-02 19:31:30 UTC
thats because the toolbar overlays the last row of effects buttons! And when the bar remains for 5sec you have a really destroyed layout! So I thought that in the effects mode you see the bar only if you make it visible by moving the mouse to the bottom of the screen and remain on the bar!
Comment 11 daniel g. siegel 2008-09-02 19:41:54 UTC
what about doing 2-3 secs on both?
Comment 12 Felix Kaser 2008-09-02 19:45:11 UTC
everyone to his taste....

tell me what you want :) I would like to keep it, because I like my idea more ;)
Comment 13 daniel g. siegel 2008-09-02 19:52:30 UTC
i just dont know why to handle things differently for the same thing
Comment 14 Felix Kaser 2008-09-02 19:55:24 UTC
its not the same =) one is preview video mode where the bar bothers no one! the other is effects mode where the bar disturbs the ui!
Comment 15 daniel g. siegel 2008-09-02 20:54:06 UTC
anyway, i committed it to svn. closing this bug

we will see what the usability guys tell us ;) felix: do you want to ask them? (usability mailing list)
Comment 16 Felix Kaser 2008-09-03 07:52:14 UTC
I will....
Comment 17 Michael Monreal 2008-09-03 08:39:43 UTC
IMHO the toolbar...

...takes too long to show (there should not be a delay to show it if the mouse is moved to the bottom)

...takes too long to vanish

...really needs to set another window hint because right now the toolbar zooms through my screen if it closes thanks to compiz thinking it is a normal window. Try making it a "Utility" window.
Comment 18 Felix Kaser 2008-09-03 08:49:28 UTC
tbh I don't see a delay in showing the bar! I really don't understand you issues, sorry!

The only thing i understand is the point "takes too long to vanish", and thats too a matter of taste isn't it? The eog toolbar timeout is set to 5seconds too....


Could you take a screencast or something? I don't understand what you mean with delay (I can't reproduce it) and what do you mean by zooming through the screen!

Either I don't see this issues on my system or it does not bother me! Probably someone else understands what you mean!

sorry
Comment 19 Michael Monreal 2008-09-03 09:26:33 UTC
I tried to do a screenscast but that does not seem to work very well with compiz :/

Ok, showing the toolbar felt slow because I again did not move the mouse to the right spot. I can move the mouse in the upper half of where the toolbar appears and it still does not appear. Also I can move it at the bottom if I quickly move it down... The zone which makes the bar appear should just be as big as the toolbar it self, perhaps even slightly larger (e.g. twice the height).

As for the zooming: compiz' default animation for closing a window is moving and zooming the window to the spot where the mouse is. For cheese this means:

- I move the mouse away from the toolbar
- I wait a few (looooong) seconds
- the toolbar quickly moves (and gets smaller in the process) from the bottom to where the mouse pointer is)

As I said, the toolbar should identify with a window class which does not have such animation by default e.g. "Utility".
Comment 20 Felix Kaser 2008-09-03 14:35:41 UTC
ahhh now I got it!

well the sensible area where the bar appears is at the very bottom of the screen! Its not the same size as the bar is, its THE ABSOLUTE BOTTOM OF THE SCREEN!

I wanted to make a area as big as the bar is, but that meant trouble, because I got the mouse movement notification only outside the preview video! Thats because I decided to avoid trouble and make the sensible area so small (there is a very small space between the video preview and the end of the screen!

about the 5seconds you have to wait until the bar disappears: Would you like to have 3 seconds instead? I think when there are no guidelines we have another bug report in 10 days of a guy who wants to have 4 or 5 seconds instead of the 3 because for him the bar disappears to fast!

about the compiz part: what do you mean with "utility" as a window class? Does that exist already or do you mean "we need that"! Because I never heart/read of it during my research! I saw that eog is using a gtkwindow which is not TOPLEVEL but POPUP instead! So I used that too, please make a concrete example what you mean, I'm not that experienced with gtkwindows and compiz!

Thanks for explaining :)
Comment 21 Michael Monreal 2008-09-03 15:24:09 UTC
Ok I ran xprop on the bar and this is what I get:

_NET_WM_WINDOW_TYPE(ATOM) = _NET_WM_WINDOW_TYPE_NORMAL

Compiz uses different animations for various window types. The default is to have some use a fancy animation and some use a less fancy one. For example, for normal app windows it's fine if they zoom out but for tooltips it's not.

So for this toolbar I would use _NET_WM_WINDOW_TYPE_UTILITY which also brings "not so fancy" animations. Perhaps even _NET_WM_WINDOW_TYPE_MENU (which should give the same result...). There's no _NET_WM_WINDOW_TYPE_FULLSCREEN_TOOLBAR though, so we have to use one of the others.

Info: http://standards.freedesktop.org/wm-spec/1.4/ar01s05.html

There's a gtk function to set the window type hints.
Comment 22 Felix Kaser 2008-09-03 17:08:59 UTC
Thanks a lot, thats exactly what I wanted to know :)

Its strange, because I read in the doc of gtkwindow that POPUP windows are not handled by the window manager (in X11)...

"In GTK+, GTK_WINDOW_POPUP means a pop-up menu or pop-up tooltip. On X11, popup windows are not controlled by the window manager."



Whatever, I found the gtk function to set the window manager class (gtk_window_set_wmclass ())! I will provide a patch ASAP!

Thx for your help!

And what about the other issues? Do you agree waiting for a gnome-guideline to decide whats best? I've already contacted the usability mailing list for this, probably they can help us...
Comment 23 Michael Monreal 2008-09-03 17:30:49 UTC
Well, it would be _really nice_ to have some kind of guideline for this... if you can help building one that would surely be great :)
Comment 24 Felix Kaser 2008-09-03 18:27:38 UTC
I was wrong....its not gtk_window_set_wmclass!

But its possible to set the hint in the glade file, I'll test it!
Comment 25 Felix Kaser 2008-09-04 14:41:48 UTC
While working on this (yes I know, I'm lazy because I havent fixed it already, but I had some problems with my 5 different cheese installations on my system), I experienced another bug... A really evil one! who crashes your X!

I hope it's a compiz bug, not a cheesy one! Can please someone (a compiz user would be great) confirm the bug!

Open cheese, start fullscreen mode and switch to effects! Then try to move your mouse to bottom and away some times! The fullscreen bar should appear when you go to bottom and disappear when you leave the bar!

I got some really bad crashes (the whole X restarted)! Sometimes at the first time the bar disappeared and sometimes after some "traffic" on the bar (appear, disappear)!

Everything works fine with metacity though...
Comment 26 Felix Kaser 2008-09-04 15:03:52 UTC
I got a crash even when I had cheese open (normal mode) and switched to compiz (with compiz fusion icon you can switch between the two window managers)!

To come back to the actual bug: I modified the glade file so the fullscreen bar gets the utility hint micheal suggested!

patch follows
Comment 27 Felix Kaser 2008-09-04 15:07:00 UTC
Created attachment 118014 [details] [review]
shows the bar at fullscreen toggle and sets the utility hint for the popup

new patch, this one shows the bar when you switch to fullscreen (exactly the same like the old patch) and the glade file has been modified to set the GDK_WINDOW_TYPE_HINT_UTILITY, so compiz should hide the popup window (the bar) with crazy effects!

For the rest, if compiz still makes some crazy things with the bar when it disappears you have to configure compiz! Mine had the setting to use the crazy effects for utility windows too!
Comment 28 daniel g. siegel 2008-09-04 16:40:31 UTC
(In reply to comment #25)
> While working on this (yes I know, I'm lazy because I havent fixed it already,
> but I had some problems with my 5 different cheese installations on my system),
> I experienced another bug... A really evil one! who crashes your X!
> 
> I hope it's a compiz bug, not a cheesy one! Can please someone (a compiz user
> would be great) confirm the bug!

does not happen here with compiz

> 
> Open cheese, start fullscreen mode and switch to effects! Then try to move your
> mouse to bottom and away some times! The fullscreen bar should appear when you
> go to bottom and disappear when you leave the bar!
> 
> I got some really bad crashes (the whole X restarted)! Sometimes at the first
> time the bar disappeared and sometimes after some "traffic" on the bar (appear,
> disappear)!
> 
> Everything works fine with metacity though...
> 

Comment 29 daniel g. siegel 2008-09-05 16:32:42 UTC
should i apply the patch and close this bug?

felix: for future patches, please do not add things, which already have been committed, thanks!
Comment 30 Felix Kaser 2008-09-06 09:11:32 UTC
what do you mean? did you already apply the first patch which I made obsolete? I was not sure about that...sorry!

I think we can close the bug! I still have no answer from the usability guys...
Comment 31 Filippo Argiolas 2008-09-06 09:25:42 UTC
What about not hiding the toolbar at all in effects selection mode?
Hiding the toolbar makes sense in preview mode because we want as much space as possible for the video.
I don't think we need so much space for effect selector and there is no need to hide the toolbar, we could just shrink down a bit the selector and leave the toolbar always visible in that mode.
Imagine if the effects selector contained gtk widgets instead of custom cairo ones, it would have been really ugly to have a toolbar overlaying the widgets.
Comment 32 Felix Kaser 2008-09-06 09:31:04 UTC
hmmm that sounds a little bit ugly too, I think! I can not explain why but it just doesn't feel right :)

I really have no idea whats best :(
Comment 33 Michael Monreal 2008-09-06 10:42:26 UTC
@Filippo: best idea yet, I think this would wok best.
Comment 34 Felix Kaser 2008-09-06 10:57:29 UTC
I think I got overruled ^^

I don't know why I don't like it, but I'm happy you like the idea michael!

The technical part will be a little bit tricky :( If we want to include the bar into the original cheese window! If we are lazy and just make the effects window smaller and show the fullscreen toolbar popup it won't be that hard!
Comment 35 daniel g. siegel 2008-09-07 20:27:23 UTC
felix: can you do it till monday? otherways we have to postbone that bug to 2.26

you can always check here if you arent sure if something was committed or not: http://svn.gnome.org/viewvc/cheese/?view=log
Comment 36 Felix Kaser 2008-09-08 09:56:35 UTC
I don't think I can make it for today! I'll look at it but at the moment I have no idea how it could work!
Comment 37 Felix Kaser 2008-10-12 19:29:24 UTC
Fixed in trunk, now the bar remains visible in effect chooser mode!