Probably just need to fiddle with activates-default on the entry. Want to try your hands at it? :)

Created attachment 119505 [details] [review]
A patch to fix default_response for the ok button, and fix the cancel button!

Hope this works out. Do I get to slap my name/email somewhere if this is accepted? What about gnome-found? How substantial of a contribution does one have to make to get in? I also fixed/worked on http://bugzilla.gnome.org/show_bug.cgi?id=207 today.

There was a very simple GTK_RESPONSE_ACCEPT instead of GTK_RESPONSE_OK, but the cancel button was also broken (it ran the same code as the ok button). I put a check in the callback which skips the screen_set_user_title function call.

Thanks,
-Ian Page Hands

Thanks for the patch!

Some comments, don't modify the indentation of already existing code, like in:

-                    G_CALLBACK (terminal_set_title_dialog_response_cb), priv->active_screen);
+		    G_CALLBACK (terminal_set_title_dialog_response_cb), priv->active_screen);

spaces where replaced by tabs. This clutters your patches.

Otherwise I think it looks pretty good, would you please update it to remove the uneeded indentation changed lines?

You get your name in the changelog for the patches you contribute and are acknowledged in the release notes for the next release of the module.
Your name is slapped in the file itself and in the authors file/about dialog when your contribution is significant, like if you added plugin capabilities to the text editor, or something like that. Or when you have contributed for quite some time a good number of patches.

Created attachment 119620 [details] [review]
A cleaner terminal-window patch, for the set titlle fix.

Sorry, I have a habit of wanting to "mark-all", "indent-region".

"Or when you have contributed for quite some time a good number of patches."
I would really like to start looking at and fixing bugs on a regular schedule (maybe a bug or two per week/weekend to start).

Let me know if this works,
-Ian

Thanks for the patch!

This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.

*** Bug 556627 has been marked as a duplicate of this bug. ***

*** Bug 571168 has been marked as a duplicate of this bug. ***