After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 547826 - Whitelist languages not known by fontconfig
Whitelist languages not known by fontconfig
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2008-08-14 19:32 UTC by Behdad Esfahbod
Modified: 2008-08-14 20:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.65 KB, patch)
2008-08-14 19:33 UTC, Behdad Esfahbod
accepted-commit_now Details | Review

Description Behdad Esfahbod 2008-08-14 19:32:26 UTC
Currently gdm does not show languages that fontconfig does not have any  knowledge about.  Attaching patch to allow them, so minority language groups are not forced to wait for a fontconfig release before gdm shows their language if they have already translated everything...

This was suggested by mclasen in response to user requests on fedora.

Patch not tested.
Comment 1 Behdad Esfahbod 2008-08-14 19:33:51 UTC
Created attachment 116605 [details] [review]
patch

Requires: fontconfig >= 2.6.0
Comment 2 Ray Strode [halfline] 2008-08-14 19:38:45 UTC
looks good to me! Thanks for working on this.  I was thinking about dropping the function entirely.
Comment 3 Behdad Esfahbod 2008-08-14 20:04:21 UTC
Hope I didn't break anything :).

2008-08-14  Behdad Esfahbod  <behdad@gnome.org>

        Bug 547826 – Whitelist languages not known by fontconfig

        * configure.ac: Require fontconfig >= 2.6.0

        * gui/simple-greeter/gdm-language-chooser-widget.c
        (language_has_font): Accept language if FcLangGetCharSet()
        returns NULL on it.