GNOME Bugzilla – Bug 547490
use a vumeter instead of progressbar for input level
Last modified: 2015-01-19 11:34:02 UTC
> Changes since 2.22.0: > > * gnome-sound-recorder now has a slick new icon, and a record > level indicator, which might have ui/usability improvements. The progress bar (tracking peak dB) could be replaced by a vumeter widget, this would bring support for both stereo tracks, and rms as well as peak level.
Created attachment 116452 [details] [review] gnome-sound-recorder with vumeter widget Implement a vumeter widget, and use it in gnome-sound-recorder. You can see it in action at http://www.0d.be/tmp/gnome-recorder-vumeter.ogv It may need some code to nicely interact wrt accessibility, but I don't know what would be needed for that.
nice! nice! nice! merci fred! Bastien, did you want to write volume widgets with some vumeter for pa volume?
Something similar, yes, but that would be integrated into the slider widget though. If Frederic fancies giving it a try :)
What's the slider widget?, I don't have pulseaudio running but I sure could give it a try.
The slider widget would be the knob you tweak to change the volume. Check the current gnome-volume-control and replace the "fill" in the sliders by a vu-meter (see the green bit in http://www.gnome.org/~clarkbw/designs/volume%20control/vista/speakers.PNG) We're also looking at using a widget exactly like yours to have in the control-center (see the sound level progress bar in the mockups at https://fedoraproject.org/wiki/Features/VolumeControl#Test_Plan_and_User_Experience)
Looks like it amounts to replacing the call to gtk_paint_slider in gtk_range_expose by custom code to draw the green/yellow/red background; I'll try to get that working tomorrow.
Frederic, I wonder if you know about this widget set (Stefan Kost is using it in Buzztard and love it): http://calf.sourceforge.net/?id=4
Looks nice; I see gtkvumeter.[ch] in buzztard source only has this license statement: "This widget has been release as freeware"; Buzztard is GPL (at least its COPYING file is, some files have LGPL headers) and gnome-sound-recorder is LGPL; some checking needs to be done here. Anyway I'll update my patch to use this widget.
Created attachment 124026 [details] [review] Use same gtkvumeter as Buzztard Rewrote patch to use the same GtkVumeter as Buzztard. Some notes: - licensing concerns (see previous comment) - doesn't really look like on calf screenshots (continuous color shade, no "unlit" color) - too bad it says "PLEASE NOTE: the falloff is not yet implemented" - should probably get away off gtk_ namespace, rename and ship in libegg? Anyway the plan to have a single vumeter widget and work on it is the best course of action.
Created attachment 124066 [details] [review] gtkvumeter rewritten to use cairo + some little changes I rewrote gtkvumeter.[ch] to use cairo (it was listed as a TODO item in the file); there is no API change. I tested the logarithmic scale option, but not the widget in vertical position.
pretty :) I am all for it!
Cool. Didn't see this until now. Was actually going to write one today!
The license of the gtkvumeter.{c,h} is clearly unacceptable as it is now. Freeware is not a license nor does it have any accepted definition. LGPL would be best I guess.
http://mumblelina.com/gtk/gtkVUMeter-gtk2.0-1.0.tar.gz has it with this header: /*************************************************************************** * gtkvumeter.c * * Fri Jan 10 20:06:23 2003 * Copyright 2003 Todd Goyen * wettoad@knighthoodofbuh.org * Source code is LGPL'd, * but may be distributed under any other open source license ****************************************************************************/ I will s/gtk/egg/ and add a standard LGPL header; hopefully tomorrow morning.
Frederic, FYI - I have integrated your back to buzztard. I also made some fixes (the gradients are diagonal) and changed the look a bit (led segments). Thanks for the cairo port! If there is still interest I can s/gtk/egg/ and reattach it here.
gnome-media has been obsolete since the release of GNOME 3, nearly 4 years ago. Furthermore, the gnome-sound-recorder program in gnome-media has been replaced by the stand-alone, rewritten, gnome-sound-recorder program which has a different interface. The new program should not be affected by the bugs you filed, however, please make sure to file new bugs against the gnome-sound-recorder product.